1992777 - SearchService.forceInitializationStatusForTests does not remove the REGION_TOPIC observer in browser_searchModeSwitcher_basic.js

Status: RESOLVED FIXED

(Firefox :: Search, task)

Description

[Jens Stutte [:jstutte]]

This is a test-only problem and was overlooked in bug 1991122. Symptom:

[task 2025-10-06T15:15:10.211+00:00] 15:15:10     INFO - GECKO(27482) | [Child 27646: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 15 (7f6e5f189500) [pid = 27646] [serial = 504] [outer = 7f6eb767b600]
[task 2025-10-06T15:15:10.242+00:00] 15:15:10     INFO - GECKO(27482) | 0 #doPreInitWork() ["resource://gre/modules/SearchService.sys.mjs":1455:18]
[task 2025-10-06T15:15:10.243+00:00] 15:15:10     INFO - GECKO(27482) |     this = [object Object]
[task 2025-10-06T15:15:10.245+00:00] 15:15:10     INFO - GECKO(27482) | 1 #init() ["resource://gre/modules/SearchService.sys.mjs":1480:24]
[task 2025-10-06T15:15:10.246+00:00] 15:15:10     INFO - GECKO(27482) |     this = [object Object]
[task 2025-10-06T15:15:10.248+00:00] 15:15:10     INFO - GECKO(27482) | 2 init() ["resource://gre/modules/SearchService.sys.mjs":495:22]
[task 2025-10-06T15:15:10.248+00:00] 15:15:10     INFO - GECKO(27482) |     this = [object Object]
[task 2025-10-06T15:15:10.251+00:00] 15:15:10     INFO - GECKO(27482) | 3 getDefault() ["resource://gre/modules/SearchService.sys.mjs":225:16]
[task 2025-10-06T15:15:10.251+00:00] 15:15:10     INFO - GECKO(27482) |     this = [object Object]
[task 2025-10-06T15:15:10.251+00:00] 15:15:10     INFO - GECKO(27482) | 4 _getDefaultSearchEngine() ["moz-src:///browser/components/urlbar/UrlbarInput.sys.mjs":4293:25]
[task 2025-10-06T15:15:10.251+00:00] 15:15:10     INFO - GECKO(27482) |     this = [object Object]
[task 2025-10-06T15:15:10.251+00:00] 15:15:10     INFO - GECKO(27482) | 5 _updatePlaceholderFromDefaultEngine() ["moz-src:///browser/components/urlbar/UrlbarInput.sys.mjs":4301:38]
[task 2025-10-06T15:15:10.251+00:00] 15:15:10     INFO - GECKO(27482) |     this = [object Object]
[task 2025-10-06T15:15:10.251+00:00] 15:15:10     INFO - GECKO(27482) | 6 onPrefChanged(pref = ""keyword.enabled"") ["moz-src:///browser/components/urlbar/UrlbarInput.sys.mjs":413:14]
[task 2025-10-06T15:15:10.251+00:00] 15:15:10     INFO - GECKO(27482) |     this = [object Object]
[task 2025-10-06T15:15:10.251+00:00] 15:15:10     INFO - GECKO(27482) | 7 #notifyObservers(method = [unavailable], changed = [unavailable]) ["moz-src:///browser/components/urlbar/UrlbarPrefs.sys.mjs":1323:27]
[task 2025-10-06T15:15:10.251+00:00] 15:15:10     INFO - GECKO(27482) | 8 observe(subject = "[xpconnect wrapped nsIPrefBranch @ 0x7f0fe1ef64c0 (native @ 0x7f101afaa900)]", topic = ""nsPref:changed"", data = ""keyword.enabled"") ["moz-src:///browser/components/urlbar/UrlbarPrefs.sys.mjs":1035:26]
[task 2025-10-06T15:15:10.252+00:00] 15:15:10     INFO - GECKO(27482) |     this = [object Object]

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 1992777 - SearchService.forceInitializationStatusForTests must remove the pre-init observer when needed. r?#search-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/16544332ee2e
https://hg.mozilla.org/integration/autoland/rev/a2b759bbc26b
SearchService.forceInitializationStatusForTests must remove the pre-init observer when needed. r=search-reviewers,Standard8

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a2b759bbc26b