1992982 - Passwords and the state of them (visible or hidden) are remembered when dismissing and reopening the Back up your sensitive data and change password dialog using ESC key

Status: VERIFIED FIXED

(Firefox :: Profile Backup, defect, P1)

Description

[Bogdan Maris, Desktop Test Engineering [OUT until 12 Jan]]

Attachment: Gif showing the issue

Found in

• Nightly 145.0a1

Affected versions

• Nightly 145.0a1

Tested platforms

• Affected platforms: Windows 10, Windows 11
• Unaffected platforms: MacOS, Ubuntu (even though the feature can also be forced turned on here as well)

Preconditions

• browser.backup.preferences.ui.enabled set to true

Steps to reproduce

1. Go to about:preferences and search for Backup
2. Click the "Manage Backup" button and "Turn on backup"
3. Click the "Back up your sensitive data" checkbox
4. Enter a random password and toggle the view/hidden icon
5. Close the dialog using the ESC key
6. Click the "Back up your sensitive data" checkbox again

• Same thing happens when using the "Change password" button

Expected result

• The password is deleted and the view pass icon is set to hidden by default every time

Actual result

• The password is remembered and the view pass icon is left in the same state as it was last used

Regression range

• Not a regression, this is also reproducible on older builds when this feature was first enabled back in 2024-09-18 in Nightly 132.0a1.

Additional notes

• This is not reproducible if user closes the dialog by the button X or Cancel.
• Note that the view pass icon also remains in the state that it was last left even though the password is saved successfully or cancel the dialog from the X or Cancel button. I can log a separate bug for the view icon if we don't want to address this in the same bug.

Comment 1

[Duncan McIntosh [:dmcintosh]]

Attachment: Bug 1992982 - Reset backup password value and visibility when containing preference dialogs close. r=#backup-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7d3fe10ccdec
https://hg.mozilla.org/integration/autoland/rev/c0481866bb1f
Reset backup password value and visibility when containing preference dialogs close. r=hsohaney

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c0481866bb1f

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dmcintosh, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox145 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Password might remain in dialog after closing it, or password fields might unintentionally be visible when opened the second time. Marked P1 for FxBackup, which is planned for a dot release.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: See STR in bug 1992982.

1. Go to about:preferences and search for 'backup'.
2. Click 'Turn on backup'.
3. Click 'Back up your sensitive data'
4. Enter something into each password box (doesn't need to match).
5. Set both to reveal the password by clicking on the eye icon.
6. Press Escape.
7. Click 'Turn on backup' and 'Back up your sensitive data'.
8. Check that the boxes are empty and not revealed.
9. Click 'Back up your sensitive data' to turn it off, and select 'Turn on backup'.
10. Click 'Back up your sensitive data' on the settings page (not in a dialog).
11. Repeat steps 4, 5, 6.
12. Click 'Back up your sensitive data' (from #10) and verify the boxes are empty and not revealed.

• Risk associated with taking this patch: low
• Explanation of risk level: Disabled by default with a pref, doesn't affect critical functionality, and has automated tests.
• String changes made/needed: no
• Is Android affected?: no

Comment 6

[Duncan McIntosh [:dmcintosh]]

Attachment: Bug 1992982 - Reset backup password value and visibility when containing preference dialogs close. r=#backup-reviewers

Original Revision: https://phabricator.services.mozilla.com/D269891

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/df7f6c9013fe
https://hg.mozilla.org/releases/mozilla-beta/rev/1080d51f1fb1

Comment 8

[Bogdan Maris, Desktop Test Engineering [OUT until 12 Jan]]

This looks fixed to me using both Firefox 145.0 and latest Nightly 146.0a1 on Windows 10 and Windows 11. Passwords are now removed when exiting a dialog that has passwords fields and also all the passwords are masked (hidden) by default.