1993079 - Implement "emulation.setNetworkConditions" command for "type: offline"

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

Spec PR landed at https://github.com/w3c/webdriver-bidi/pull/948 with support for offline only at the moment.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Given that it is not clear when the other network specific emulation types will land, lets concentrate on the offline mode first.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1993079 - [bidi] Use helper for all emulation commands and use NULL symbol for missing parameter

This commit:

• updates the getEmulationTargets helper to also handle commands which support global configuration
• updates setUserAgentOverride to use the same helpers as the others
• creates a new helper to simplify the individual commands
• switches to NULL for all missing contextIds/userContextIds parameter

This refactor allows to implement the setNetworkConditions command easily.
This new command supports global configuration, and has tests against the None/null value.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1993079 - [wdspec] Update all invalid tests for emulation commands to check null not accepted for contexts/userContexts

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1993079 - [bidi] Add support for emulation.setNetworkConditions command

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1993079 - [wdspec] Cleanup network configurations at the end of user_contexts tests

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1993079 - [remote] Include TestExpectations.json in toolchain paths for puppeteer

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7a5ad5b82d88
https://hg.mozilla.org/integration/autoland/rev/1e81f7876111
[bidi] Use helper for all emulation commands and use NULL symbol for missing parameter r=Sasha
https://github.com/mozilla-firefox/firefox/commit/d4f2ce66a626
https://hg.mozilla.org/integration/autoland/rev/f1004d3636cc
[wdspec] Update all invalid tests for emulation commands to check null not accepted for contexts/userContexts r=Sasha
https://github.com/mozilla-firefox/firefox/commit/cca4c93d0a97
https://hg.mozilla.org/integration/autoland/rev/1ea7e1e5f9e2
[bidi] Add support for emulation.setNetworkConditions command r=Sasha
https://github.com/mozilla-firefox/firefox/commit/63f066db317b
https://hg.mozilla.org/integration/autoland/rev/a1c53b618049
[wdspec] Cleanup network configurations at the end of user_contexts tests r=Sasha
https://github.com/mozilla-firefox/firefox/commit/2a1ce1081346
https://hg.mozilla.org/integration/autoland/rev/810045a3d6ff
[remote] Include TestExpectations.json in toolchain paths for puppeteer r=Sasha

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58066 for changes under testing/web-platform/tests

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1e81f7876111
https://hg.mozilla.org/mozilla-central/rev/f1004d3636cc
https://hg.mozilla.org/mozilla-central/rev/1ea7e1e5f9e2
https://hg.mozilla.org/mozilla-central/rev/a1c53b618049
https://hg.mozilla.org/mozilla-central/rev/810045a3d6ff

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged