1993095 - Don't expose "application/x-moz-file" on drag and drop

Status: REOPENED

(Core :: DOM: Copy & Paste and Drag & Drop, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

This type is non-standard and is breaking drag and drop of files into fiverr.com.

If we still want to keep this around it would be valuable to disable it per-origin.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

This was added in bug 1290688

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Nika, can we stop exposing "application/x-moz-file" to web content?

Comment 3

[Nika Layzell [:nika] (ni? for response)]

It looks like at least at some point in the past I thought we needed to keep "application/x-moz-file" around for backwards compatibility (https://searchfox.org/firefox-main/rev/1c6a8b56e6f5f5393ea5ea745ab63ecb67613c93/dom/events/DataTransfer.cpp#480-482, https://searchfox.org/firefox-main/rev/1c6a8b56e6f5f5393ea5ea745ab63ecb67613c93/dom/events/DataTransferItemList.cpp#453-455, https://bug1342057.bmoattachments.org/attachment.cgi?id=8841081).

Looking at that bug (bug 1342057), it appears like it was a web-compat issue and was being uplifted, so I may have been doing this out of caution at the time, and perhaps we could safely hide kFileMime now, hiding GetInternalType more consistently.

Unfortunately, D&D is very poorly tested, so we'd need to do a good chunk of manual testing to make sure that things still work, especially internal consumers of the D&D APIs.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Just came across bug 1290688 comment 13, which appears to explicitly note that we have internal code which depends on "application/x-moz-file" being there.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Yeah, unfortunately it doesn't mention which code :)

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1993095. Don't include "application/x-moz-file" in types.

The existance of kFileMime ("application/x-moz-file") in types
is breaking drag and drop on fiverr.com. We don't seem to need it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/781eb0294d9a
https://hg.mozilla.org/integration/autoland/rev/9bc30f795593
Don't include "application/x-moz-file" in types. r=tschuster

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a9582148b310
https://hg.mozilla.org/integration/autoland/rev/349861fa92a0
Revert "Bug 1993095. Don't include "application/x-moz-file" in types. r=tschuster" for causing bc failures @ browser_clipboard_paste_file_content_analysis.js

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_clipboard_paste_file_content_analysis.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/349861fa92a04f29e474de117fdfdb1783776256

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/contentanalysis/tests/browser/browser_clipboard_paste_file_content_analysis.js | Correctly pasted file in content - Got "Error: FAIL: expected 2 got 1 - Correct number of types", expected "test-file.txt"

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/57330b084578
https://hg.mozilla.org/integration/autoland/rev/0623447fa4e5
Don't include "application/x-moz-file" in types. r=tschuster

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0623447fa4e5

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0c22beffb811
https://hg.mozilla.org/integration/autoland/rev/13ba9793db2e
Revert "Bug 1993095. Don't include "application/x-moz-file" in types. r=tschuster" for causing mochitests failures in test_paste_image.html.

Comment 13

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in test_paste_image.html.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/events/test/clipboard/test_paste_image.html | undefined assertion name - Structures begin differing at:

Comment 14

[amarc]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/13ba9793db2e

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/49beffa1c066
https://hg.mozilla.org/integration/autoland/rev/eb869d3a7000
Don't include "application/x-moz-file" in types. r=tschuster

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/eb869d3a7000

Comment 17

[Atila Butkovits]

Backed out as requested.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/3808d2de01e89751e731fd701b32f92e1e45d79a