[composable toolbar] “Allow” and “Don’t Allow” buttons not visible in landscape mode
Categories
(Firefox for Android :: Toolbar, defect)
Tracking
()
People
(Reporter: apetridean, Assigned: moyin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][group3])
Attachments
(2 files, 1 obsolete file)
Steps to reproduce
- Perform a fresh install and open the Private Browsing homepage.
- Rotate the device into landscape mode and start typing in the search URL.
- Observe the behavior.
Expected Result:
Both “Allow” and “Don’t Allow” buttons from the “Allow search suggestions in private sessions” prompt remain visible and accessible in all screen orientations.
Actual Result:
In landscape mode, the buttons are not visible, making it impossible to proceed without switching back to portrait mode.
Device information
Firefox version: Nightly 145.0a1 from 10/07
Android devices: Google Pixel 3 XL (Android 9), Samsung Galaxy S23 Ultra (Android 14)
| Reporter | ||
Updated•6 months ago
|
| Reporter | ||
Comment 1•6 months ago
|
||
Comment 2•6 months ago
|
||
Hello,
Not sure this is a new bug specific to the new toolbar.
Doesn't it reproduce also with the old toolbar?
| Reporter | ||
Comment 3•6 months ago
•
|
||
Hi! This issue is reproducible when Composable is enabled. When the experiment is disabled, the buttons are initially not visible, but the page can be scrolled, allowing the user to access them (please see the video with Composable turned off).
Comment 4•6 months ago
|
||
Thanks!
Seems like the fix would be to also make that banner scrollable.
Updated•6 months ago
|
Updated•6 months ago
|
Updated•6 months ago
|
| Assignee | ||
Updated•4 months ago
|
| Assignee | ||
Comment 5•4 months ago
|
||
The fix will work when tab strips are disabled. But there's a still a bug when tab strips are turned on, because the banner won't be visible at all.
Comment 6•4 months ago
|
||
(In reply to Moyin Adeyemi [:moyin] from comment #5)
The fix will work when tab strips are disabled. But there's a still a bug when tab strips are turned on, because the banner won't be visible at all.
Would've been great if the "extracted UI" functionality would work in Compose to help avoid this case.
But it doesn't - https://issuetracker.google.com/issues/203549026.
This issue is highly dependent on the device tested though, there will be devices helped by us "fixing" it while on others the users would have to just close the keyboard to see this banner / search results.
| Assignee | ||
Comment 7•4 months ago
|
||
That means we can't really mark the ticket as done even with a fix. I wonder if it's better to leave it as blocked instead.
Comment 8•4 months ago
•
|
||
(In reply to Moyin Adeyemi [:moyin] from comment #7)
That means we can't really mark the ticket as done even with a fix. I wonder if it's better to leave it as blocked instead.
Current issue is a regression from moving to the new toolbar.
Based on comment 3 the old toolbar handled things a bit better.
So IMO a fix for this ticket would be to just get the same behaviour that we had before, where possible. Then we can open a separate ticket for the scenarios still having issues.
Description
•