1993306 - retrigger-multiple action's schema is broken

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Julien Cristau [:jcristau] (back on 2026-01-06)]

The retrigger-multiple schema is making treeherder sad, due to:

> const Ajv = require("ajv")
undefined
> const ajv = new Ajv()
undefined
> const retrigger_schema = {"type": "object", "properties": {"requests": {"type": "array", "items": {"tasks": {"type": "array", "description": "An array of task labels", "items": {"type": "string"}}, "times": {"type": "integer", "minimum": 1, "maximum": 100, "title": "Times", "description": "How many times to run each task."}, "additionalProperties": false}}, "additionalProperties": false}}
{
  type: 'object',
  properties: {
    requests: { type: 'array', items: [Object] },
    additionalProperties: false
  }
}
> ajv.compile(retrigger_schema)
Uncaught Error: strict mode: unknown keyword: "tasks"
    at checkStrictMode (/home/jcristau/src/github.com/mozilla/treeherder/node_modules/ajv/dist/compile/util.js:174:15)
    at checkUnknownRules (/home/jcristau/src/github.com/mozilla/treeherder/node_modules/ajv/dist/compile/util.js:32:13)
    at alwaysValidSchema (/home/jcristau/src/github.com/mozilla/treeherder/node_modules/ajv/dist/compile/util.js:19:5)
    at Object.code (/home/jcristau/src/github.com/mozilla/treeherder/node_modules/ajv/dist/vocabularies/applicator/items.js:17:42)
    at keywordCode (/home/jcristau/src/github.com/mozilla/treeherder/node_modules/ajv/dist/compile/validate/index.js:454:13)

Comment 1

[Julien Cristau [:jcristau] (back on 2026-01-06)]

Attachment: Bug 1993306 - fix retrigger-multiple action's json schema. r?#taskgraph

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d3c31b9e7480
https://hg.mozilla.org/integration/autoland/rev/f4ca05c5dfcf
fix retrigger-multiple action's json schema. r=taskgraph-reviewers,releng-reviewers,bhearsum

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f4ca05c5dfcf