Closed
Bug 1993311
Opened 2 months ago
Closed 7 days ago
shape() commands hline and vline have overpermissive parsing
Categories
(Core :: Layout: Floats, defect)
Core
Layout: Floats
Tracking
()
RESOLVED
FIXED
147 Branch
| Tracking | Status | |
|---|---|---|
| firefox147 | --- | fixed |
People
(Reporter: sukil, Assigned: sukil)
References
(Blocks 1 open bug)
Details
(Whiteboard: css-shape-function, [wptsync upstream])
Attachments
(1 file)
Based off Bug 1917128, it improves hline and vline parsing to allow <position> values to be parsed. However, the parse_to_position method used can incorrectly accept 2 offsets for hline or vline. For example: hline to left 30% will work.
Furthermore, hline and vline currently does not accept x-start/x-end and y-start/y-end respectively, though it should based off spec.
Addendum: Relevant tests to run. Also our <position> parsing is also too permissive, so this specific invalid test is parsed.
|
||
Updated•2 months ago
|
|
Assignee | |
Updated•1 month ago
|
Assignee: nobody → sukil
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•1 month ago
|
||
Pushed by sukil@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/8257df91aa31
https://hg.mozilla.org/integration/autoland/rev/a1346e39038a
Update hline and vline command parsing to support <position> values. r=boris,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,longsonr
|
||
Comment 3•7 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 days ago
status-firefox147:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56450 for changes under testing/web-platform/tests
Whiteboard: css-shape-function → css-shape-function, [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
You need to log in
before you can comment on or make changes to this bug.
Description
•