1993344 - Fail to sync from Firefox desktop

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Clare So]

Starting on Oct 4, some Firefox iOS sync integration tests fail (See *_desktop ones) due to an error from Sync from the staging server. Here Firefox desktop attempts to sync some bookmarks with the server. Those errors occurred before Firefox iOS was launched and attempts to sync

1759596984683	Sync.SyncScheduler	TRACE	Handling weave:engine:sync:finish
1759596984683	Sync.Telemetry	TRACE	observed weave:engine:sync:finish bookmarks
1759596984683	Sync.Synchronizer	INFO	Sync completed at 2025-10-04 09:56:24 after 0.33 secs.
1759596984683	Sync.Service	TRACE	Event: weave:service:sync:error
1759596984684	Sync.ErrorHandler	TRACE	Handling weave:service:sync:error
1759596984684	Sync.ErrorHandler	ERROR	Sync encountered an error: [Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://services-sync/stages/enginesync.sys.mjs :: sync :: line 216"  data: no] Stack trace: sync()@resource://services-sync/stages/enginesync.sys.mjs:216

Full log: https://storage.googleapis.com/mobile-reports/public/firefox-ios-M4/firefox-ios-sync-integration-tests/result_1129/firefox-ios/firefox-ios-tests/Tests/SyncIntegrationTests/results/assets/test_integration.py__test_sync_bookmark_from_desktop_1_0.txt

2025-10-04 09:56:24.686 CROSSWEAVE ERROR: [phase phase1] Sync error; aborting test - JS Stack trace: [e-mail]:160:37
[e-mail]:218:18
[e-mail]:83:18
[e-mail]:183:19
[e-mail]:193:17

Full log: https://storage.googleapis.com/mobile-reports/public/firefox-ios-M4/firefox-ios-sync-integration-tests/result_1129/firefox-ios/firefox-ios-tests/Tests/SyncIntegrationTests/results/assets/test_integration.py__test_sync_bookmark_from_desktop_3_0.txt

1759596984942	SessionStore	DEBUG	SessionWriter.write wrote 872 bytes in 3ms
console.error: services.settings:
Object
  - prototype Object
    - columnNumber = 0
    - data = null
    - filename = resource://gre/modules/ServiceRequest.sys.mjs
    - lineNumber = 126
    - location = {"name":"open","filename":"resource://gre/modules/ServiceRequest.sys.mjs","sourceId":26,"lineNumber":126,"columnNumber":11,"asyncCause":null,"asyncCaller":null,"caller":{"filename":"resource://services-settings/Utils.sys.mjs","name":"fetch/<","sourceId":25,"lineNumber":272,"columnNumber":15,"asyncCause":null,"asyncCaller":null,"caller":{"filename":"resource://services-settings/Utils.sys.mjs","name":"fetch","sourceId":25,"lineNumber":223,"columnNumber":12,"asyncCause":null,"asyncCaller":null,"caller":{"filename":"resource://services-settings/Utils.sys.mjs","name":"fetchLatestChanges","sourceId":25,"lineNumber":433,"columnNumber":34,"asyncCause":null,"asyncCaller":null,"caller":{"filename":"resource://services-settings/RemoteSettingsClient.sys.mjs","name":"sync","sourceId":23,"lineNumber":658,"columnNumber":42,"asyncCause":null,"asyncCaller":null,"caller":{"filename":"resource://services-settings/RemoteSettingsClient.sys.mjs","name":"get/this._importingPromise<","sourceId":23,"lineNumber":496,"columnNumber":28,"asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"get/this._importingPromise<@resource://services-settings/RemoteSettingsClient.sys.mjs:496:28\n","nativeSavedFrame":{}},"formattedStack":"sync@resource://services-settings/RemoteSettingsClient.sys.mjs:658:42\nget/this._importingPromise<@resource://services-settings/RemoteSettingsClient.sys.mjs:496:28\n","nativeSavedFrame":{}},"formattedStack":"fetchLatestChanges@resource://services-settings/Utils.sys.mjs:433:34\nsync@resource://services-settings/RemoteSettingsClient.sys.mjs:658:42\nget/this._importingPromise<@resource://services-settings/RemoteSettingsClient.sys.mjs:496:28\n","nativeSavedFrame":{}},"formattedStack":"fetch@resource://services-settings/Utils.sys.mjs:223:12\nfetchLatestChanges@resource://services-settings/Utils.sys.mjs:433:34\nsync@resource://services-settings/RemoteSettingsClient.sys.mjs:658:42\nget/this._importingPromise<@resource://services-settings/RemoteSettingsClient.sys.mjs:496:28\n","nativeSavedFrame":{}},"formattedStack":"fetch/<@resource://services-settings/Utils.sys.mjs:272:15\nfetch@resource://services-settings/Utils.sys.mjs:223:12\nfetchLatestChanges@resource://services-settings/Utils.sys.mjs:433:34\nsync@resource://services-settings/RemoteSettingsClient.sys.mjs:658:42\nget/this._importingPromise<@resource://services-settings/RemoteSettingsClient.sys.mjs:496:28\n","nativeSavedFrame":{}},"formattedStack":"open@resource://gre/modules/ServiceRequest.sys.mjs:126:11\nfetch/<@resource://services-settings/Utils.sys.mjs:272:15\nfetch@resource://services-settings/Utils.sys.mjs:223:12\nfetchLatestChanges@resource://services-settings/Utils.sys.mjs:433:34\nsync@resource://services-settings/RemoteSettingsClient.sys.mjs:658:42\nget/this._importingPromise<@resource://services-settings/RemoteSettingsClient.sys.mjs:496:28\n","nativeSavedFrame":{}}
    - message =
    - name =
    - result = 2152071198
    - stack = open@resource://gre/modules/ServiceRequest.sys.mjs:126:11|fetch/<@resource://services-settings/Utils.sys.mjs:272:15|fetch@resource://services-settings/Utils.sys.mjs:223:12|fetchLatestChanges@resource://services-settings/Utils.sys.mjs:433:34|sync@resource://services-settings/RemoteSettingsClient.sys.mjs:658:42|get/this._importingPromise<@resource://services-settings/RemoteSettingsClient.sys.mjs:496:28|
  - prototype Object

https://storage.googleapis.com/mobile-reports/public/firefox-ios-M4/firefox-ios-sync-integration-tests/result_1129/firefox-ios/firefox-ios-tests/Tests/SyncIntegrationTests/results/assets/test_integration.py__test_sync_bookmark_from_desktop_2_0.txt

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:skhamis, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Clare So]

I've encountered an error on sync keys. Could someone let me know if there's something missing on my end to get TPS working?

                if 'CROSSWEAVE ERROR: ' in line:
>                   raise TPSError(line.partition('CROSSWEAVE ERROR: ')[-1])
E                   SyncIntegrationTests.tps.TPSError: [phase phase1] Configuring sync failed. - Error: User does not have sync keys(resource://services-sync/service.sys.mjs:1000:13) JS Stack trace: [e-mail]:1000:13

https://storage.googleapis.com/mobile-reports/public/firefox-ios-M4/firefox-ios-sync-integration-tests/result_1176/firefox-ios/firefox-ios-tests/Tests/SyncIntegrationTests/results/index.html?sort=result

Comment 3

[Clare So]

Note that the error occurred on the desktop's side, not Firefox iOS mobile.

The logs when all tests passed:
https://storage.googleapis.com/mobile-reports/public/firefox-ios-M1/result_1115/firefox-ios/firefox-ios-tests/Tests/SyncIntegrationTests/results/index.html?sort=result

:markh Do you recall any changes in sync or TPS around the end of September and the beginning of October?

Comment 4

[Clare So]

I just had a brief chat with Sammy K. We confirmed that the errors are from the recent changes in sync, not from Firefox iOS.

Comment 6

[Sammy Khamis [:skhamis]]

Attachment: Bug 1993344: Fix some TPS tests r=markh

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/59fe74e10413
https://hg.mozilla.org/integration/autoland/rev/32ef4c3123e2
Fix some TPS tests r=markh,credential-management-reviewers,sync-reviewers,dimi

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/32ef4c3123e2