1993397 - ReviewPromptMiddleware testing should evaluate the real expression

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, task)

Description

[Jonathan Almeida [:jonalmeida]]

Some of the existing tests aren't exercising the criteria for the jexl expressions we are evaluating - we should really improve the test suite because it's relying on subtle details of Nimbus behaviour and the fakes are not cutting it (e.g. the fakes directly return the test value and bypass the jexl parser).

In the cases related to bug 1992918, having coverage testing between switching criteria respects the 4 month check would be a good addition.

Testing on Nimbus is a tiny bit more trickier, but since our work here is built around this, I think that would be a fine investment in learning.

Comment 1

[Jonathan Almeida [:jonalmeida]]

While I'm working on bug 1923209, this bug can be unblocked by building app services locally and using the autopublish workflow to run the tests locally on Apple Silicon.

Comment 2

[Marcin Koziński]

Attachment: Bug 1993397 - Add tests for JEXL expressions in ReviewPromptMiddleware

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/531f84bff4d5
https://hg.mozilla.org/integration/autoland/rev/db33edd74282
Add tests for JEXL expressions in ReviewPromptMiddleware r=android-reviewers,gmalekpour

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/db33edd74282