1993555 - [ews] ReplyTo can only contain a single recipient but should be able to contain multiple.

Status: RESOLVED FIXED

(MailNews Core :: Networking: Exchange, defect)

Description

[Eleanor Dicharry]

We saw an example in the wild of email messages being returned with multiple recipients in the ReplyTo field, but ews-rs is only allowing a single value. The documentation for that field of an Item states "Identifies a set of addresses to which replies should be sent.", so I think we're in the wrong here. I'll verify the multiplicity of the other fields while I'm fixing this.

Comment 1

[Eleanor Dicharry]

The symptom of this issue appears to be failing to download messages, which is something we've seen a smattering of reports for.

Comment 2

[Eleanor Dicharry]

Attachment: Bug 1993555 - Allow multiple reply-to addresses on emails. r=#thunderbird-back-end-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/efdfb2936679
Allow multiple reply-to addresses on emails. r=babolivier

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5cb9862e2908
Backed out changeset efdfb2936679

Comment 5

[Kai Engert [:KaiE:]]

Fails to build locally for me.

0:08.74 Updating git repository https://github.com/thunderbird/ews-rs.git
0:09.30 error: failed to get ews as a dependency of package ews_xpcom v0.1.0 (/home/user/moz/commcent/mozilla/comm/rust/ews_xpcom)
0:09.30 Caused by:
0:09.30 failed to load source for dependency ews
0:09.30 Caused by:
0:09.31 Unable to update https://github.com/thunderbird/ews-rs.git?rev=ad3c9077987cbf28e9c60a868e5a258e20d4ba70
0:09.31 Caused by:
0:09.31 failed to fetch into: /home/user/.cargo/git/db/ews-rs-fe995326286edf48
0:09.32 Caused by:
0:09.32 attempting to update a git repository, but --frozen was specified

Comment 6

[Eleanor Dicharry]

Sorry about that, I forgot to tb-rust vendor. Should be good to go now.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c0fe82ef215b
Allow multiple reply-to addresses on emails. r=babolivier

Comment 8

[Eleanor Dicharry]

Comment on attachment 9519383 [details]
Bug 1993555 - Allow multiple reply-to addresses on emails. r=#thunderbird-back-end-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: This is a fix for an issue that blocks Thunderbird from downloading emails.
• User impact if declined: This bug causes user emails to fail to download.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: Yes
• If yes, steps to reproduce: 1. Set up an EWS account.

2. Send an email to the EWS account with multiple addresses in the reply-to header.
3. Ensure the email displays correctly when received in Thunderbird.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change reads multiple items from a header instead of a single header and sets them as a string property on the email in Thunderbird.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed:

Comment 9

[Corey Bryant]

Comment on attachment 9519383 [details]
Bug 1993555 - Allow multiple reply-to addresses on emails. r=#thunderbird-back-end-reviewers

[Triage Comment]
Approved for beta

Comment 10

[Corey Bryant]

Thunderbird 145.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/cc16e92fbe59