199358 - [modern] need cut/copy/paste/find toolbar icons for html editor [classic complete]

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[(not reading, please use [e-mail] instead)]

need cut/copy/paste toolbar icons for html editor (modern and classic)

I'll attach a screen shot of the icons from 4.x

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: 4.x screen shot

Comment 2

[(not reading, please use [e-mail] instead)]

these would be added to btn1.gif

for modern, see
http://lxr.mozilla.org/mozilla/source/themes/modern/editor/icons/btn1.gif

for classic, see
http://lxr.mozilla.org/mozilla/source/themes/classic/editor/icons/btn1.gif

Comment 3

[[e-mail]]

Adding dependency so we can enable the prefs on when the icons are in.

Comment 4

[Ben Bucksch (:BenB)]

Looks like a plain old dup to me.

Comment 5

[(not reading, please use [e-mail] instead)]

neil, do we need a toolbar icon for "Find" as well?  (looking at the editor
toolbar prefs, it looks like we might)

Comment 6

[(not reading, please use [e-mail] instead)]

hoping adam might be able to help out.

Comment 7

[Adam Becevello]

I'd love to help out with this bug, but since this involves actually making the
icons I can't do this.  The only icon hacking I've done is easy stuff like
putting images into the icon map (btn1.gif).  Since I don't really have much
artistic talent, I don't think it would be good for me to make these icons
(xul/css is more in my league).

Comment 8

[(not reading, please use [e-mail] instead)]

ok, thanks adam.

I'm going to ask on [e-mail]

Comment 9

[Patrick Thompson]

Attachment: Revised editor btn1

Updated classic btn1.gif file for the new editor buttons. Below are the
stylesheet changes for editorPrimaryToolbar.css:



/* Sailfish - added cut/copy/paste icons on March 05, 03 */

#cutButton {
  -moz-image-region: rect(227px 16px 243px 0);
}

#cutButton:hover {
  -moz-image-region: rect(227px 32px 243px 16px);
}

#cutButton:hover:active {
  -moz-image-region: rect(227px 48px 243px 32px);
}

#cutButton[disabled="true"] {
  -moz-image-region: rect(227px 64px 243px 48px) !important;
}

#copyButton {
  -moz-image-region: rect(243px 16px 259px 0);
}

#copyButton:hover {
  -moz-image-region: rect(243px 32px 259px 16px);
}

#copyButton:hover:active {
  -moz-image-region: rect(243px 48px 259px 32px);
}

#copyButton[disabled="true"] {
  -moz-image-region: rect(243px 64px 259px 48px) !important;
}

#pasteButton {
  -moz-image-region: rect(259px 16px 275px 0);
}

#pasteButton:hover {
  -moz-image-region: rect(259px 32px 275px 16px);
}

#pasteButton:hover:active {
  -moz-image-region: rect(259px 48px 275px 32px);
}

#pasteButton[disabled="true"] {
  -moz-image-region: rect(259px 64px 275px 48px) !important;
}

#findButton {
  -moz-image-region: rect(276px 16px 292px 0);
}

#findButton:hover {
  -moz-image-region: rect(276px 32px 292px 16px);
}

#findButton:hover:active {
  -moz-image-region: rect(276px 48px 292px 32px);
}

#findButton[disabled="true"] {
  -moz-image-region: rect(276px 64px 292px 48px) !important;
}

Comment 10

[(not reading, please use [e-mail] instead)]

patrick, thanks for the classic icons and the classic css!

I've tested and landed both.

can you help with modern?

Comment 11

[Patrick Thompson]

seth, I'd want to know more about modern before I attempted to create the new
images. Things like what the background fill metrics are (colors, gradients,
multi-color, fill directions) for each of the four button states, the shadow
metrics for the images, the desired icon angle orientation (it appears to be
somewhere between 15-30 degrees??), etc.

Given this info., sure, I'd take a stab at it... 

Comment 12

[(not reading, please use [e-mail] instead)]

I don't know the answers to your question, but I'll try to find out from gail or
marlon.

in the mean time, here's the btn1.gif for modern, if that helps:

http://lxr.mozilla.org/mozilla/source/themes/modern/editor/icons/btn1.gif

Comment 13

[Patrick Thompson]

seth, thanks for the link but I am able to see it via openning the modern.jar
file, as well.

It was viewing those icons which prompted me to pose the questions. Hopefully,
the information is available somewhere???

Comment 14

[(not reading, please use [e-mail] instead)]

re-assign back to gail.  I didn't realize she had already started on the modern
icons.

patrick, sorry for the thrashing.  thanks again for the classic icon work.

Comment 15

[Patrick Thompson]

Not a problem ... I was pleased to assist even in this small way.

Comment 16

[(not reading, please use [e-mail] instead)]

> Not a problem ... I was pleased to assist even in this small way.

thanks for understanding.  

and, it's not a small way, as it will unblock bug #54802.

Comment 17

[(not reading, please use [e-mail] instead)]

update, gail thinks she can have an updated btn1.gif for modern skin sometime today.

(I'll attach a screenshot).

for 1.4 final, I can land that, and the .css changes, and then we can fix bug #54802

Comment 18

[(not reading, please use [e-mail] instead)]

Attachment: screenshot of modern

Comment 19

[sairuh (rarely reading bugmail)]

nice!

Comment 20

[(not reading, please use [e-mail] instead)]

I've landed a new btn1.gif from gail, and the necessary .css changes.

marking fixed.

Comment 21

[Patrick Thompson]

These Modern icons are stunning, kudos to the designer (gail?)!

Any attempt by me would have been pale in comparison...

Comment 22

[(not reading, please use [e-mail] instead)]

patrick, thanks for the positive feedback.  (we usually only get the other kind)

I agree, gail has (once again) delivered some great icons.

thanks again for your help with classic.

Comment 23

[sairuh (rarely reading bugmail)]

just a trivial observation: afaict, the tooltips are missing for the Cut, Copy
and Paste buttons. filed bug 206499.

Comment 24

[(not reading, please use [e-mail] instead)]

Attachment: updated classic skin, from gail

Comment 25

[Chris Petersen]

As per my comments in 54802:

Using the 2003-05-20-03 Macho build, Cut,Paste, and Copy toolbar icons are
displayed in Classic and Modern themes (when enabled in Preferences - Composer -
Toolbars). Also, verifying the icons are functional when copying a selection,
cutting a selection, and pasting a selection. 

However, I noticed no tooltip is displayed when hovering over either cut, copy,
or paste icons.

Comment 26

[Chris Petersen]

Verified on 2003-05-21-08 Win32 trunk and 2003-05-20-03 Macho trunk builds.