1993582 - Tidy: Create JSMicroTask type alias, and use through public/MicroTask.h & CycleCollectedJSContext

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

There's this awkward API problem in the SM microtask queue. Basically, we have classes of functions which can't handle a non-JS-originated Microtask (e.g. some MicrotaskRunnable stored as a PrivateValue). However, right now the signature can't express this constraint, because everything basically works on either MicroTask or UncopyableMicroTask.

We can, and should, fix this by instead having JSMicroTask or something similar as a top level type. This would be both a .toObject and a validation of the class; but then after we know it's a JSMicroTask we can express the limitations of the API at the type level instead.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Some broken patches that explain basically what I mean are here. These patches get the wrapping/unwrapping wrong, but generally are what I mean.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1993582 - Fix missed use of typedef r?arai

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1993582 - Rename JS::MicroTask to JS::GenericMicroTask r?arai

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1993582 - Disambiguiate MicroTask kinds at the C++ type level r?arai!,smaug!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7326d5e59a3b
https://hg.mozilla.org/integration/autoland/rev/eac5c9aaf018
Fix missed use of typedef r=arai
https://github.com/mozilla-firefox/firefox/commit/6d8788fd1572
https://hg.mozilla.org/integration/autoland/rev/0f97df9346c3
Rename JS::MicroTask to JS::GenericMicroTask r=arai
https://github.com/mozilla-firefox/firefox/commit/ff7da48b891c
https://hg.mozilla.org/integration/autoland/rev/996140601bc8
Disambiguiate MicroTask kinds at the C++ type level r=arai,smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0a0abe40bbe8
https://hg.mozilla.org/integration/autoland/rev/8b434e72bd1e
Revert "Bug 1993582 - Disambiguiate MicroTask kinds at the C++ type level r=arai,smaug" for causing hazard bustages @ Promise.cpp

Comment 7

[amarc]

Backed out for causing hazard bustages

• Backout link
• Push with failures
• Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/455b7f7a80b3
https://hg.mozilla.org/integration/autoland/rev/583ecf7f7fb7
Fix missed use of typedef r=arai
https://github.com/mozilla-firefox/firefox/commit/a51e51840327
https://hg.mozilla.org/integration/autoland/rev/a3e43647574d
Rename JS::MicroTask to JS::GenericMicroTask r=arai
https://github.com/mozilla-firefox/firefox/commit/22f7b88f8530
https://hg.mozilla.org/integration/autoland/rev/120d1351bd3d
Disambiguiate MicroTask kinds at the C++ type level r=arai,smaug

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/583ecf7f7fb7
https://hg.mozilla.org/mozilla-central/rev/a3e43647574d
https://hg.mozilla.org/mozilla-central/rev/120d1351bd3d