199384 - UTF-8 filename is needed for mach-o fopen/PR_Open

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[nhottanscp]

This is separated from local mail folder bug 172472.
For mach-o, fopen and PR_Open requires filename as UTF-8. Because this is mach-o
specific the XP callers pass filename as platform charset.
I heard that nsLocalFile for Mac also takes UTF-8 filename now. We can change
the platform charset to be UTF-8 for MacOS X. In order to do that, nsIFileSpec
need to change to take care UTF-8 filename.

Comment 1

[nhottanscp]

nsbeta1
I think this is also "embed" but I do not have an actual example.
Basically, wherever using fopen/PR_Open cannot open non-Ascii filenames in
mach-o build. A known problem is that non-Ascii local mail folder cannot be
created (bug 172472).

Comment 2

[nhottanscp]

I spend time debugging and found opening a file for nsIFileSpec is done by
PR_Open for mach-o. 
Note that the code below is in #else part of #ifdef XP_MAC but XP_MAC is not
defined for mach-o (very confusing).

http://lxr.mozilla.org/seamonkey/source/xpcom/obsolete/nsIFileStream.cpp#284

284     //    Platforms other than Macintosh...
285     //  Another bug in NSPR: Mac PR_Open assumes a unix style path, but Win
PR_Open assumes
286     //  a windows path.
287     if ((mFileDesc = PR_Open((const char*)nsFileSpec(inFile), nsprMode,
accessMode)) == 0)
288         return NS_FILE_RESULT(PR_GetError());

Anyway, at least open file for nsIFileSpec works with UTF-8 filename 
(need to confirm this with ccarlen),
I think we can change the platform charset for mach-o to UTF-8.

Comment 3

[nhottanscp]

Attachment: Return UTF-8 as a platform file charset.

Comment 4

[Conrad Carlen (not reading bugmail)]

Comment on attachment 118709 [details] [diff] [review]
Return UTF-8  as a platform file charset.

r=ccarlen. The FS charset on Mach-O is either UTF-8 or UCS-2, depending on
which APIs are used.

Which code is creating nsFileSpecs with paths mapped by uconv? I think this is
only a problem in that case. If using nsILocalFile, this shouldn't be a
problem.

Comment 5

[nhottanscp]

>Which code is creating nsFileSpecs with paths mapped by uconv?
Some mail code like import use nsFileSpec, also several other places in mail/news.
And mozilla/db/mork does not use xpcom/io but calls fopen directly.

Comment 6

[nhottanscp]

reassign to nhotta

Comment 7

[Darin Fisher]

Comment on attachment 118709 [details] [diff] [review]
Return UTF-8  as a platform file charset.

sr=darin

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 118709 [details] [diff] [review]
Return UTF-8  as a platform file charset.

a=asa (on behalf of drivers) for checkin to 1.4a but this needs to land fast if
it's gonna make it.

Comment 9

[nhottanscp]

checked in to the trunk

Comment 10

[Greg K.]

Does this fix bug 194618, also?

Comment 11

[Samir Gehani]

*** Bug 200008 has been marked as a duplicate of this bug. ***