1993863 - "Choose browser" button in about:firefoxview#history > "Import history from another browser" banner bypasses DisableProfileImport enterprise policy

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[aoia7rz7l]

Tested on 140.3.1esr and Nightly 145.0a1 (2025-10-11) BuildID 20251011212838.

Prerequisite:

Set the DisableProfileImport policy to true (You might need to modify mozregression/launchers.py in order to reproduce this using mozregression).

STR:

1. Press the Alt key and select File > Import From Another Browser.
2. Confirm that the Import From Another Browser option is greyed out.
3. Open the Library.
4. Click on Import and Backup > Import Data from Another Browser.
5. Confirm that the Import Data from Another Browser option is also greyed out.
6. Open about:preferences.
7. Confirm that the Import Browser Data section is hidden.
8. Open about:firefoxview#history.

Expected Behavior:

No "Import history from another browser" banner offering to Choose browser when the DisableProfileImport policy is set to true.

Actual Behavior:

The "Import history from another browser" banner offered users the option to Choose browser, thus bypassing the DisableProfileImport policy.

mozregression --good 115 --bad 140 --pref browser.tabs.firefox-view-next:true returned

Last good revision: 89d21fac92b8f98201b8715c6c050aace4b46afb (2023-07-17)
First bad revision: 9330f8cb5765b67a89ac1427300f344a63d42cdc (2023-07-18)
Pushlog : https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=89d21fac92b8f98201b8715c6c050aace4b46afb&tochange=9330f8cb5765b67a89ac1427300f344a63d42cdc
Switching bisection method to taskcluster
Getting mozilla-central builds between 89d21fac92b8f98201b8715c6c050aace4b46afb and 9330f8cb5765b67a89ac1427300f344a63d42cdc
...
There are no build artifacts for these changesets (they are probably too old).

It's probably bug 1826604.

I have tentatively marked the affected OSes as Windows-only, because I wasn't able to trigger the banner in my Linux environment where Firefox "couldn't find any programs that contain bookmark, history or password data".

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Firefox View' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:kcochrane, since you are the author of the regressor, bug 1826604, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Kelly Cochrane [:kcochrane]]

Mike, the link to that enterprise template states the "Disables the “Import data from another browser” option in the bookmarks window.". Is this outdated wording and does it actually apply to bookmarks and all history entry points? If so, we'll probably need to disable it in the new sidebar as well because we show a similar button in the history panel.

Comment 4

[Mike Kaply [:mkaply]]

It's outdated wording. I'll update.

I added checks to a lot of places in the past to cover this.

https://searchfox.org/firefox-main/search?q=%22profileImport%22&path=&case=false&regexp=false

Comment 5

[Kelly Cochrane [:kcochrane]]

Adding the firefox view whiteboard tag.

Comment 6

[Mike Kaply [:mkaply]]

I swear I did this for Firefox View but I can't find it.

Comment 7

[Mike Kaply [:mkaply]]

This would be easier to just do in the "shouldshowimport" function:

https://bugzilla.mozilla.org/show_bug.cgi?id=1993863#c3

I'll do a quick patch.

Comment 8

[Mike Kaply [:mkaply]]

Attachment: Bug 1993863 - Don't show import message when import is disabled via policy. r?kcochrane

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1826604

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1af94ca4e813
https://hg.mozilla.org/integration/autoland/rev/df570a23e2be
Don't show import message when import is disabled via policy. r=kcochrane,fxview-reviewers

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/df570a23e2be

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mkaply, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox145 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[Mike Kaply [:mkaply]]

Too late for 145. I'll request uplift to ESR in the next cycle.

Comment 14

[Ciprian Georgiu, Desktop QA]

I've repro this issue using an affected Nightly build with STR from comment 0 on Win 11.

The issue is verified as fixed on Beta 146.0b2 under Win 11.

Comment 15

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined: Parity with Firefox 146
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Low. Only adds an extra policy check
• String changes made/needed: No
• Is Android affected?: no

Comment 16

[Mike Kaply [:mkaply]]

Attachment: Bug 1993863 - Don't show import message when import is disabled via policy.

Original Revision: https://phabricator.services.mozilla.com/D270680

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/15bc1616f453

Comment 18

[Monica Chiorean]

I was able to reproduce the issue on Win11 using Firefox build 145.0a1(20251011090504) using steps from description.
Verified as fixed on Win11 using Firefox build 140.6.0esr(20251201132345) using steps from description.