199393 - Don't assert if image blocking prefs aren't present

Status: RESOLVED DUPLICATE of bug 224339

(Core :: Graphics: Image Blocking, defect)

Description

[Brian Ryner (not reading)]

Currently, nsImgManager throws an assertion if any of the image blocking default
prefs aren't present (i.e. GetBoolPref fails).  This isn't right, especially
since one of those defaults is in mailnews.js, which it's perfectly reasonable
not to have.

Comment 1

[[e-mail]]

can we switch back to the NS_WARNING pattern we had before darin asked for the
assertion change?

i.e. instead of

  rv = ReadPrefs();
  NS_ASSERTION(NS_SUCCEEDED(rv), "Error occured reading image preferences");

should be

  rv = ReadPrefs();
  if (NS_FAILED(rv))
    NS_WARNING("Error occured reading image preferences");

the reason darin wanted this warning in the first place, was to make it obvious
in case someone has horked the prefservice (e.g. embeddors) - we shouldn't fall
back to defaults silently.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

I guess this is fixed with bug 224339.

*** This bug has been marked as a duplicate of 224339 ***