1994034 - rename failedCertChain to something like handshakeCertificates and make it always available

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) [:keeler]]

nsITransportSecurityInfo.failedCertChain consists of the certificates the peer sent during the handshake. Currently it is only set if the handshake failed. It would be useful (e.g. for qwacs) if it were always available, in which case it should be named something more like handshakeCertificates.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Attachment: Bug 1994034 - make TLS handshake certificates always available r?jschanck

This patch renames nsITransportSecurityInfo.failedCertChain to
handshakeCertificates and makes the property always available (after the
handshake has completed, that is).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ed038d676033
https://hg.mozilla.org/integration/autoland/rev/c018843be287
make TLS handshake certificates always available  r=jschanck,necko-reviewers,extension-reviewers,kershaw,robwu

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ea45be222fc0
https://hg.mozilla.org/integration/autoland/rev/21c0d2fe5126
Revert "Bug 1994034 - make TLS handshake certificates always available r=jschanck,necko-reviewers,extension-reviewers,kershaw,robwu" for causing mochitest failures on test_cache_padding.html

Comment 4

[Cristina Horotan [:chorotan]]

Backed out for causing mochitest failures on test_cache_padding.html

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/71a99f8c272b
https://hg.mozilla.org/integration/autoland/rev/2a14d0de8769
make TLS handshake certificates always available  r=jschanck,necko-reviewers,extension-reviewers,kershaw,robwu,dom-worker-reviewers,edenchuang

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2a14d0de8769