1994126 - [material 3] Some options are barely visible when entering Settings from private mode with Light theme

Status: VERIFIED FIXED

(Firefox for Android :: Design System and Theming, defect)

Description

[Mira Lobontiu (Android QA)]

Attachment: material3bug.jpg

Steps to reproduce

1. From private mode, open three-dot menu - Settings.
2. Go to Privacy and security - HTTPS-Only mode, and observe.
3. Exit, then go to Site settings, and observe.
4. Exit, then go to Delete browsing data, tap on "Delete browsing data" and observe the prompt's options.
5. Exit, then go to Advanced - Extensions and observe the "Reviews: no" texts.
6. Exit settings, and open a page in private mode and download a file - observe the prompt.

Expected behavior

All the elements are visible.

Actual behavior

All the mentioned elements are barely visible - please see the screenshots attached.

Device information

• Firefox version: 146.0a1. 145.0b1
• Android device: Oppo Find X3 Lite (Andorid 11), Samsung Galaxy S24 (Android 15)

Any additional information?

• step 3 - the site settings icons are the same also on RC 144 build, but the rest of the elements are displayed ok on the release version

Comment 1

[Walter K.]

Attachment: More_Color_Settings_Issues.png

There are more Settings screens to check for similar issues in the private mode:

1. Search
2. Search->Default search engine
3. Autofill

Comment 2

[Iorga Gabriel]

Attachment: Bug 1994126 - Fix colour issues in private mode for setting options.

Comment 3

[Walter K.]

Attachment: toolbar_customisation.FirefoxNightly.png

There is a new place now where Settings colors need fixing:

• Turn on Enable Toolbar Customization in Secret Settings
• Observe Settings -> Customize -> Toolbar shortcut section

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/36927b24f4e6
https://hg.mozilla.org/integration/autoland/rev/f6461848f81a
Fix colour issues in private mode for setting options. r=android-reviewers,tthibaud

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f6461848f81a

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:giorga, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox146 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Iorga Gabriel]

Comment on attachment 9522263 [details]
Bug 1994126 - Fix colour issues in private mode for setting options.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Some settings options will not be visible.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Mira Lobontiu (Android QA)]

Attachment: 1994126.jpg

Verified as fixed on the latest Firefox for Android 147.0a1 from 11/11 using an Oppo Find X3 Lite (Android 11).

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9522263 [details]
Bug 1994126 - Fix colour issues in private mode for setting options.

Approved for 146.0b3

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/fed9b49a4d6d
https://hg.mozilla.org/releases/mozilla-beta/rev/5ce9be1ef9fa

Comment 13

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: Screenshot_20251117-172715.png

This issue is verified as fixed on Firefox for Android 146 beta 3 on Google Pixel 10 Pro (Android 16) and Samsung S24 Ultra (Android 15). All the elements are visible in Private mode.

Comment 14

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: Screenshot_20251117-172745.png

Comment 15

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: Screenshot_20251117-172803.png

Comment 16

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: Screenshot_20251117-172825.png

Comment 17

[Kestrel]

The payment expiration date dropdowns are still affected on latest Nightly 147.0a1 (Bug 1996453).