1994191 - Clean-up riscv64 branching code

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P5)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1994191 - Part 1: Clean-up riscv branching code. r=#spidermonkey-reviewers!

Changes:

• Avoid loading zero immediate into a register.
• Remove duplicate code in ma_branch.
• Always try short jumps in ma_branch if the label is already bound.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1994191 - Part 2: Prefer comparison against zero. r=#spidermonkey-reviewers!

Comparing against zero doesn't require to load the immediate 1 into a register.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1994191 - Part 3: Add branch float helpers to request short jumps. r=#spidermonkey-reviewers!

This avoids code duplication.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1994191 - Part 4: Fix early return in FloatMinMaxHelper. r=#spidermonkey-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/453e8da7933f
https://hg.mozilla.org/integration/autoland/rev/c94390be8c16
Part 1: Clean-up riscv branching code. r=spidermonkey-reviewers,iain
https://github.com/mozilla-firefox/firefox/commit/9d56e2c7adbf
https://hg.mozilla.org/integration/autoland/rev/2dca26a60503
Part 2: Prefer comparison against zero. r=spidermonkey-reviewers,iain
https://github.com/mozilla-firefox/firefox/commit/18bb76985052
https://hg.mozilla.org/integration/autoland/rev/adfe3caff52c
Part 3: Add branch float helpers to request short jumps. r=spidermonkey-reviewers,iain
https://github.com/mozilla-firefox/firefox/commit/d18a1d8dfe43
https://hg.mozilla.org/integration/autoland/rev/bee70a3d58d8
Part 4: Fix early return in FloatMinMaxHelper. r=spidermonkey-reviewers,iain

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/c94390be8c16
https://hg.mozilla.org/mozilla-central/rev/2dca26a60503
https://hg.mozilla.org/mozilla-central/rev/adfe3caff52c
https://hg.mozilla.org/mozilla-central/rev/bee70a3d58d8