Closed Bug 1994290 Opened 6 months ago Closed 6 months ago

[wpt-sync] Sync PR 55430 - Update at-rule() implementation and test to match CSSWG resolutions

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
146 Branch
Tracking Flags:
Tracking Status
firefox146 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 55430 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/55430
Details from upstream follow.

Kevin Babbitt <kbabbitt@microsoft.com> wrote:

Update at-rule() implementation and test to match CSSWG resolutions

https://github.com/w3c/csswg-drafts/issues/6966#issuecomment-3205037703

  • Cut down the at-rule test to just at-rule(@foo) (no descriptor
    testing)

https://github.com/w3c/csswg-drafts/issues/11116#issuecomment-3205061108

  • at-rule(@charset) is invalid, but at-rule(@import) is allowed

https://github.com/w3c/csswg-drafts/issues/11117#issuecomment-3205069621

  • at-rule() can test for at-rules that are only valid inside other
    at-rules (like at-rule(@swash))

Bug: 40211832
Change-Id: I6493d61fbd89394935b62459cae4166795c5a0da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7037634
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Kevin Babbitt \<kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1529694}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 15 subtests

Status Summary

Firefox

OK : 1[GitHub] 10[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
PASS: 3[GitHub] 1614[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 8

Chrome

OK : 1
PASS: 9
FAIL: 2

Safari

OK : 1
PASS: 3
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-conditional/js/supports-at-rule.html [wpt.fyi]
    • @supports at-rule: FAIL (Chrome: PASS, Safari: FAIL)
    • @supports at-rule 1: FAIL (Chrome: PASS, Safari: FAIL)
    • @supports at-rule 2: FAIL (Chrome: PASS, Safari: FAIL)
    • @supports at-rule 3: FAIL (Chrome: PASS, Safari: FAIL)
    • @supports at-rule 4: FAIL (Chrome: PASS, Safari: FAIL)
    • @supports at-rule 6: FAIL (Chrome: PASS, Safari: FAIL)
    • @supports at-rule 7: FAIL (Chrome: PASS, Safari: FAIL)
    • @supports at-rule 8: FAIL (Chrome: PASS, Safari: FAIL)

https://hg.mozilla.org/mozilla-central/rev/6f0cfbdaa77c
https://hg.mozilla.org/mozilla-central/rev/f89cccc17647

Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox146: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
You need to log in before you can comment on or make changes to this bug.