Closed
Bug 1994297
Opened 7 months ago
Closed 4 months ago
Consider to avoid setting `display: unset` for result menu in flight status suggestions
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
148 Branch
| Tracking | Status | |
|---|---|---|
| firefox148 | --- | fixed |
People
(Reporter: daisuke, Assigned: daisuke)
References
Details
(Whiteboard: [sng])
Attachments
(1 file)
In the implementation of flight status suggestions, we set display: unset and visibility: hidden to prevent from breaking the layout upon hover. However, avoid changing especially display style would be nice since we already set display style to the same element once.
https://phabricator.services.mozilla.com/D266312#change-SqKqEqKNYcNd
In this bug, we want to solve everything with one style if possible.
|
||
Updated•7 months ago
|
Assignee: nobody → daisuke
Severity: -- → N/A
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [sng]
|
||
Updated•7 months ago
|
|
Assignee | |
Comment 1•5 months ago
|
||
Pushed by dakatsuka.birchill@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/976f513a8646
https://hg.mozilla.org/integration/autoland/rev/52e7cf5fd633
Avoid setting display: unset r=desktop-theme-reviewers,urlbar-reviewers,dao
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox148:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
|
||
Updated•4 months ago
|
QA Whiteboard: [search] [qa-triage-done-c148/b147]
You need to log in
before you can comment on or make changes to this bug.
Description
•