Uplift bug 1986431, bug 1988488
Categories
(Core :: Graphics: WebGPU, defect, P1)
Tracking
()
People
(Reporter: ErichDonGubler, Assigned: ErichDonGubler)
References
Details
(Keywords: sec-other, Whiteboard: [adv-main145-] patch for sec-high bugs)
Attachments
(1 external file, 1 obsolete file)
| Assignee | ||
Updated•1 year ago
|
| Assignee | ||
Comment 1•1 year ago
|
||
Updated•1 year ago
|
| Assignee | ||
Updated•1 year ago
|
Comment 2•1 year ago
|
||
Did you mean to request uplift to beta (145) rather than release (144)? Or do you really intend to ship this in a 144.0.x update? Wouldn't you still need a beta uplift request in that case? And where did these fixes land on nightly? Maybe bug 1992842?
| Assignee | ||
Comment 3•1 year ago
|
||
Did you mean to request uplift to beta (145) rather than release (144)? Or do you really intend to ship this in a 144.0.x update? Wouldn't you still need a beta uplift request in that case?
I backported to Stable, but not Beta, because I'd erroneously thought that the fixes had already landed before soft freeze for Beta.
And where did these fixes land on nightly? Maybe bug 1992842?
Unfortunately, we're still waiting for Nightly fixes to land, which is why bug 1986431 and bug 1988488 are still open.
:dmeehan has asked me if there was a way to split the revendoring done by patches here, so we can associate them with their respective bugs. This is possible, just some significant effort to manage. I may close this bug and file patches directly against those bugs instead, depending on others' posture.
Comment 4•1 year ago
|
||
:ErichDonGubler, it's difficult to track what's need here and if it's still appropriate for the planned dot release.
Bug 1986431 and Bug 1988488 are still open, but there is a depends on bug (Bug 1995050) that fixes them?
Maybe Fx145 is a better target and there is time to get appropriate beta uplifts in?
| Assignee | ||
Comment 5•1 year ago
|
||
:dmeehan: As of half an hour before your message, we're just waiting on confirmation from the filer of those issues to confirm a fix in Nightly. I will file a patch stack for Beta with this bug now, so that things are ready to be landed once confirmed. You can make the call for which patches to take at that point. π
| Assignee | ||
Comment 6•1 year ago
|
||
Updated•1 year ago
|
Updated•1 year ago
|
Comment 8•1 year ago
|
||
I'll reject the release uplift request since Bug 1986431 is still open. This can ride the train with Fx145.
Updated•1 year ago
|
Comment 9•1 year ago
|
||
(In reply to Donal Meehan [:dmeehan] from comment #8)
I'll reject the release uplift request since Bug 1986431 is still open. This can ride the train with Fx145.
The vendoring of the upstream in bug 1995050 landed on nightly 146 -- it's not riding any train to 145; this bug is trying to get cherry-picked patches for bug 1986431 and bug 1988488 uplifted to 145.
it would have been less confusing to have each cherry-picked patch attached to the security bug it's trying to fix. Is the build set up so that we can't just apply patches on top of the upstream code without having to vendor it first? That could really bite us if we ever have to fix something here in an emergency chemspill.
Comment 10•1 year ago
|
||
(In reply to Daniel Veditz [:dveditz] from comment #9)
This can ride the train with Fx145.
it's not riding any train to 145
This can "ride train" was in relation to going to release and just meant as a comment on why the release uplift was cancelled. It will still need an uplift to beta.
:ErichDonGubler, can you take a look at :dveditz questions in Comment 9?
Comment 11•1 year ago
|
||
Erich, could you also file the uplift request form to document the riskiness of the patch? Thanks
Comment 12•1 year ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: If declined, we leave users open to these vulnerabilities to two
sec-highsecurity vulnerabilities until the current Nightly train catches up with them. - Code covered by automated testing: no
- Fix verified in Nightly: yes
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: See reproduction steps for bug 1986431 and bug 1988488.
- Risk associated with taking this patch: low
- Explanation of risk level: These have been verified to fix a problem, and only limit resource usage. There is little to no risk for existing control flow otherwise.
- String changes made/needed: No.
- Is Android affected?: no
| Assignee | ||
Comment 13•1 year ago
|
||
(In reply to Daniel Veditz [:dveditz] from comment #9)
it would have been less confusing to have each cherry-picked patch attached to the security bug it's trying to fix. Is the build set up so that we can't just apply patches on top of the upstream code without having to vendor it first? That could really bite us if we ever have to fix something here in an emergency chemspill.
I don't disagree. I did offer to do that to :dmeehan (which didn't get an explicit response, now that I think about it) via DM, but I wasn't sure if it was necessary or desirable, so I left the thought of splitting at that. Guess I know now it would be helpful to do so! π If we really need to, I can still split into multiple patches. It would have to be strictly sequenced, since we would have to consume a sequence of commits upstream to make this work.
:pascalc: Done!
Updated•1 year ago
|
Updated•1 year ago
|
Comment 14•1 year ago
|
||
| uplift | ||
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Reproduced the crash on Firefox 145.0a1 (2025-09-15) on Ubuntu 24.04 with the attachment provided in Bug 1988488.
The crash is no longer reproducible on Firefox 145.0b9 (treeherder build) and Firefox 146.0a1 (2025-10-29) on the same system.
Comment 16•1 year ago
|
||
It probably makes more sense to track the advisories for this in bug 1986431 and bug 1988488.
| Assignee | ||
Comment 17•11 months ago
|
||
Note that :aleiserson has filed bug 2002393 to handle this question from :dveditz in the depth it deserves:
Is the build set up so that we can't just apply patches on top of the upstream code without having to vendor it first? That could really bite us if we ever have to fix something here in an emergency chemspill.
Sorry I dropped the ball on that, and thanks for picking it up, Andy!
Updated•5 months ago
|
Description
•