1994568 - try m2m auth (for code review, WPTSync, hackbot bots)

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement)

Description

[Olivier Mehani [:shtrom]]

We need a different flow for bots to be able to push to try via lando.

This may require updates to mach try to auth to Auth0 in a different way to obtain the access_token.

Known bot/usecases:

• reviewbot https://github.com/mozilla/code-review/tree/master/bot
• WPTSyncBot
• UpdateBot https://github.com/mozilla-services/updatebot
• HackBot

Comment 1

[Olivier Mehani [:shtrom]]

On the device-flow and refresh_token https://mozilla-hub.atlassian.net/browse/IAM-1935?focusedCommentId=1359151

Comment 2

[BMO Github Automation]

Attachment: [mozilla-conduit/lando] tests: remove deprecated/skipped test_try (bug 1994568) (#1407)

Comment 3

[BMO Github Automation]

Attachment: [mozilla-conduit/lando] try_api: enable HeadlessAPIAuthentication for M2M (bug 1994568) (#1408)

Comment 4

[Olivier Mehani [:shtrom]]

As a stop-gap, let's start with using headless API tokens.

Comment 5

[Olivier Mehani [:shtrom]]

Attachment: [mozilla-conduit/lando] headless_api: make HeadlessAPIAuthentication chainable with other NinjaAPI authenticators (bug 1994568) - #1410

Comment 6

[BMO Github Automation]

Authored by https://github.com/shtrom
https://github.com/mozilla-conduit/lando/commit/c306815aa6e0a5c47e9c5d68a947a130abc388f2
[main] tests: remove deprecated/skipped test_try (bug 1994568) r=sheehan

Comment 7

[Olivier Mehani [:shtrom]]

Attachment: [mozilla-conduit/lando-cli] cli: inspect detail and details keys on error (bug 2059648) - #20

Comment 8

[Olivier Mehani [:shtrom]]

https://github.com/mozilla-conduit/lando-cli/pull/20 needs to land first to handle a difference in error reponse format.

Comment 9

[BMO Github Automation]

Authored by https://github.com/shtrom
https://github.com/mozilla-conduit/lando/commit/4d011e1898d32cb04ac7c8d8ab3b0c755ff2a4af
[main] headless_api: make HeadlessAPIAuthentication chainable with other NinjaAPI authenticators (bug 1994568) r=sheehan

Comment 10

[BMO Github Automation]

Authored by https://github.com/shtrom
https://github.com/mozilla-conduit/lando/commit/c7a2c47dac1480107393697997066929ea08b7bc
[main] try_api: enable HeadlessAPIAuthentication for M2M (bug 1994568) r=sheehan,zeid

Comment 11

[Olivier Mehani [:shtrom]]

ni: :Shasha for FYI: we should now be able to issue a token for the WPT bot to push to Try via lando. Feel free to file a bug for us to set that up when you're ready to try it out!

Comment 12

[Marco Castelluccio [:marco]]

Anything left here?

Comment 13

[Olivier Mehani [:shtrom]]

Ideally, we should use proper OAuth m2m. But in practice, I think this works well enough as-is. We can circle back if more is needed.