1994674 - Make position-try-fallbacks swap and adjust percentages and anchor lookups.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

flip-{block,inline} should also flip the percentages in the relevant axes for the inset properties.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1994674 - Adjust margins / insets for flips. r=#anchor-pos

The flip-start logic is still not quite right, but the set-up is easy.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1994674 - Adjust sizes for flips. r=#anchor-pos,#layout

We need to adjust for anchor-size(height) becoming anchor-size(width)
and so on. Luckily the infrastructure added on the previous patch
extends nicely to this.

And make the trait work with a mutable ref because it makes the calc
code a bit easier and more compact.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fc08f7bd773b
https://hg.mozilla.org/integration/autoland/rev/61020f3c8146
Adjust margins / insets for flips. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,dshin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5133ef8effde
https://hg.mozilla.org/integration/autoland/rev/37dcda84a0f2
Adjust sizes for flips. r=layout-anchor-positioning-reviewers,layout-reviewers,firefox-style-system-reviewers,dshin

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/61020f3c8146

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/37dcda84a0f2