1994825 - Add a pref to disable only using windows on the current virtual desktop

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Greg Stoll :gstoll]

Some users have asked for a way to turn off the behavior introduced in bug 1423768.

Comment 1

[jscher2000]

Related SUMO thread: https://support.mozilla.org/questions/1536551

Comment 2

[Greg Stoll :gstoll]

Attachment: Bug 1994825 - add a pref to restore the old behavior of not considering virtual desktops in getTopWindow() r=#win-reviewers!

Some users have asked for this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/84504d1bb6af
https://hg.mozilla.org/integration/autoland/rev/98510e7aed95
add a pref to restore the old behavior of not considering virtual desktops in getTopWindow() r=win-reviewers,handyman

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/98510e7aed95

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Some users have been annoyed with the change in behavior; this provides a pref to undo that change.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: Very simple change to add a pref
• String changes made/needed: No
• Is Android affected?: no

Comment 6

[Greg Stoll :gstoll]

Attachment: Bug 1994825 - add a pref to restore the old behavior of not considering virtual desktops in getTopWindow() r=#win-reviewers!

Some users have asked for this.

Original Revision: https://phabricator.services.mozilla.com/D268951

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/08eb73e19c9d
https://hg.mozilla.org/releases/mozilla-beta/rev/a643d9553884

Comment 10

[Greg Stoll :gstoll]

Release Note Request (optional, but appreciated)
[Why is this notable]: new pref per a user request to change virtual desktop behavior
[Affects Firefox for Android]: no
[Suggested wording]: Added a new pref widget.prefer_windows_on_current_virtual_desktop that, when set to false, will make external links opened from outside of Firefox to open in the most recently used Firefox window, regardless of what virtual desktop was on. Setting the pref to false reverts this behavior to what it was before Firefox 144, and was added on user request.
[Links (documentation, blog post, etc)]: (SUMO page, but it's not live yet so I don't know if we want to link to it): https://support.mozilla.org/en-US/kb/control-how-firefox-uses-multiple-desktops-windows

Comment 11

[Pascal Chevrel:pascalc]

Merged with the relnote request in bug 1995597 and reworded for end-users with this text:

Improved control over Firefox windows on multiple desktops:
Firefox now offers new preferences to customize how windows and tabs open or restore across virtual desktops, giving you more flexibility when using multiple desktops. Learn more