1994828 - ESM: Add initial support for fetching wasm modules

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Dan Minor [:dminor]]

See changes in https://github.com/whatwg/html/pull/10380/files.

Comment 1

[Dan Minor [:dminor]]

I'm going to scope this initial bug according to the note at the top of https://webassembly.github.io/esm-integration/js-api/index.html#esm-integration, specifically: "In this case, the ResolveExport abstract operation should be implemented as returning null, and the InitializeEnvironment and ExecuteModule abstract operations implemented as unconditionally throwing a SyntaxError exception."

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add ModuleType::JavaScriptOrWasm to reflect specification change; r=allstarschh!

This has been renamed to "javascript-or-wasm" in the specification.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add pref for wasm/esm integration; r=allstarschh!

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add HasWasmMimeTypeEssence; r=#dom-core!

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add checks for wasm mime type for script loading; r=#dom-core!,#necko-reviewers!

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Track wasm mime type essence in ModuleLoadRequest; r=allstarschh!

The only way we can distinguish between JavaScript and wasm modules is
using the mime type in the response. This adds a field to track this
information in the load request.

Comment 7

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Set wasm mime type on module request; r=#dom-core!

Comment 8

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add empty JS::CompileWasmModule; r=allstarschh!

Comment 9

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add ModuleEnvironmentObject::createWasm; r=allstarschh!

Comment 10

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add support for wasm modules in module loaders; r=#dom-core!,allstarschh!

Comment 11

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add error message for unsupported operations on wasm modules; r=allstarschh!

Comment 12

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add support for wasm modules to ModuleObject; r=allstarschh!

Comment 13

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Check for wasm modules in JS::GetModuleScript; r=allstarschh!

Comment 14

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Handle InitializeEnvironment and ResolveExport for wasm modules; r=allstarschh!

Since we don't support full evaulation/instance phase integration, we
throw on InitializeEnvironment and return null for ResolveExport.

Comment 15

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Set pref for esm-integration tests and update expected results; r=allstarschh!

Comment 16

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add shell option for wasm/esm integration; r=allstarschh!

Comment 17

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Support wasm modules in shell; r=allstarschh!

Comment 18

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add basic jit-test for wasm modules; r=allstarschh!

This checks that we can parse a wasm module, and that attempting to
link it will throw a SyntaxError as expected.

Comment 19

[Dan Minor [:dminor]]

I'm going to scope this bug even smaller, and just add support for fetching wasm modules in this bug. I'll file follow ups to cover the other patches I originally had on this bug.

Comment 20

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Don't cache wasm modules; r=arai!

Comment 21

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Set wasm mime type for worker requests; r=#dom-worker-reviewers!

Comment 22

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Add wasm to mimetype check in ScriptResponseHeaderProcessor.cpp; r=#dom-worker-reviewers!

Comment 23

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Set wasm mime type essence for worklets; r=allstarschh!

Comment 24

[Dan Minor [:dminor]]

Attachment: Bug 1994828 - Allow service workers to load wasm modules; r=#dom-worker-reviewers!

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/22ab64ea6d4b
https://hg.mozilla.org/integration/autoland/rev/40b07d51d5b5
Add ModuleType::JavaScriptOrWasm to reflect specification change; r=allstarschh,dom-worker-reviewers,asuth
https://github.com/mozilla-firefox/firefox/commit/754a58c63513
https://hg.mozilla.org/integration/autoland/rev/5444c6f25ed3
Add pref for wasm/esm integration; r=allstarschh
https://github.com/mozilla-firefox/firefox/commit/b6c54c546d7e
https://hg.mozilla.org/integration/autoland/rev/521f575d58a3
Add HasWasmMimeTypeEssence; r=dom-core,smaug
https://github.com/mozilla-firefox/firefox/commit/29510a29713b
https://hg.mozilla.org/integration/autoland/rev/a20026a4833a
Add checks for wasm mime type for script loading; r=dom-core,necko-reviewers,smaug,sunil
https://github.com/mozilla-firefox/firefox/commit/092a9faecc5b
https://hg.mozilla.org/integration/autoland/rev/467c90d79ed5
Track wasm mime type essence in ModuleLoadRequest; r=allstarschh
https://github.com/mozilla-firefox/firefox/commit/67234fcc689f
https://hg.mozilla.org/integration/autoland/rev/4ba2fa139419
Set wasm mime type on module request; r=dom-core,smaug
https://github.com/mozilla-firefox/firefox/commit/dab845c9edf7
https://hg.mozilla.org/integration/autoland/rev/956cd9b7d24e
Add empty JS::CompileWasmModule; r=allstarschh
https://github.com/mozilla-firefox/firefox/commit/26107c4f6374
https://hg.mozilla.org/integration/autoland/rev/d0d00cd30f0f
Don't cache wasm modules; r=arai
https://github.com/mozilla-firefox/firefox/commit/5c2dc323f00d
https://hg.mozilla.org/integration/autoland/rev/b894b8e202b2
Add support for wasm modules in module loaders; r=allstarschh,dom-core,smaug
https://github.com/mozilla-firefox/firefox/commit/dac591595425
https://hg.mozilla.org/integration/autoland/rev/b4b97092cbf2
Set wasm mime type for worker requests; r=dom-worker-reviewers,edenchuang
https://github.com/mozilla-firefox/firefox/commit/c06884446e58
https://hg.mozilla.org/integration/autoland/rev/2a4b97162023
Add wasm to mimetype check in ScriptResponseHeaderProcessor.cpp; r=dom-worker-reviewers,edenchuang
https://github.com/mozilla-firefox/firefox/commit/d9af9be984bd
https://hg.mozilla.org/integration/autoland/rev/e7a2a3052ddc
Set wasm mime type essence for worklets; r=allstarschh
https://github.com/mozilla-firefox/firefox/commit/18958bfdef8b
https://hg.mozilla.org/integration/autoland/rev/a4cac8f679b4
Allow service workers to load wasm modules; r=dom-worker-reviewers,edenchuang
https://github.com/mozilla-firefox/firefox/commit/88571c466f03
https://hg.mozilla.org/integration/autoland/rev/cd6d393e47d9
Set pref for esm-integration tests and update expected results; r=allstarschh

Comment 26

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/40b07d51d5b5
https://hg.mozilla.org/mozilla-central/rev/5444c6f25ed3
https://hg.mozilla.org/mozilla-central/rev/521f575d58a3
https://hg.mozilla.org/mozilla-central/rev/a20026a4833a
https://hg.mozilla.org/mozilla-central/rev/467c90d79ed5
https://hg.mozilla.org/mozilla-central/rev/4ba2fa139419
https://hg.mozilla.org/mozilla-central/rev/956cd9b7d24e
https://hg.mozilla.org/mozilla-central/rev/d0d00cd30f0f
https://hg.mozilla.org/mozilla-central/rev/b894b8e202b2
https://hg.mozilla.org/mozilla-central/rev/b4b97092cbf2
https://hg.mozilla.org/mozilla-central/rev/2a4b97162023
https://hg.mozilla.org/mozilla-central/rev/e7a2a3052ddc
https://hg.mozilla.org/mozilla-central/rev/a4cac8f679b4
https://hg.mozilla.org/mozilla-central/rev/cd6d393e47d9