1994855 - Crash in [@ mozilla::widget::StatusBarEntry::OnMessage] (diagnostic assert)

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/03a04efd-945e-479a-addc-263fd0251015

MOZ_CRASH Reason:

MOZ_DIAGNOSTIC_ASSERT(widget)

Top 10 frames:

0  xul.dll  mozilla::widget::StatusBarEntry::OnMessage(HWND__*, unsigned int, unsigned lo...  widget/windows/SystemStatusBar.cpp:189
1  xul.dll  mozilla::widget::WindowProc(HWND__*, unsigned int, unsigned long long, long l...  widget/windows/SystemStatusBar.cpp:246
2  user32.dll  UserCallWinProcCheckWow(_ACTIVATION_CONTEXT*, int64_t (*)(tagWND*, unsigned i...
3  user32.dll  DispatchClientMessage
4  user32.dll  _fnDWORD
5  ntdll.dll  KiUserCallbackDispatch
6  win32u.dll  ZwUserPeekMessage
7  user32.dll  _PeekMessage(tagMSG*, HWND__*, unsigned int, unsigned int, unsigned int, unsi...
8  user32.dll  PeekMessageW
9  msctf.dll  CThreadInputMgr::PeekMessageW(tagMSG*, HWND__*, unsigned int, unsigned int, u...

This assertion is old, but it seems to have started showing up on Nightly 146, build id 20251014213342. Here is the set of changes in that build.

Emilio, could this be related to bug 1994157? That's the bug I found when I searched for "widget" in that change log. Thanks.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

This probably comes from bug 1933181 instead, but that assert is wrong afaict, it's not flushing and we're now creating the widget a bit later, so there might be a popupframe without a widget more often. Looking at https://hg-edge.mozilla.org/mozilla-central/rev/5823cb0f699866c8672cce50cf8e1cbceadc43aa it wasn't clear these asserts were correct to begin with.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1994855 - Remove assert that doesn't hold. r=#win-reviewers

This spike probably comes from bug 1933181, but that assert is wrong
afaict. It's not flushing and we're now creating the widget a bit later,
so there might be a popupframe without a widget more often.

Looking at the commit that introduced these, it wasn't clear these
asserts were correct to begin with.

https://hg-edge.mozilla.org/mozilla-central/rev/5823cb0f699866c8672cce50cf8e1cbceadc43aa

I think the assert below (every widget hanging from a popup having an
hwnd) should hold.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/874e87e76929
https://hg.mozilla.org/integration/autoland/rev/6ddf853b1c99
Remove assert that doesn't hold. r=win-reviewers,handyman

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6ddf853b1c99