1994891 - Implement `transfer` for AudioDataInit

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, task, P3)

Description

[C.M.Chang[:chunmin]]

Similar to Bug 1861769, we should add a transfer property to AudioDataInit's WebIDL and follow the latest AudioData constructor algorithm. This will allow users to transfer ownership of data from a TypedArray to the AudioData, avoiding unnecessary copies. (See Bug 1861769, comment 1 for more details and rationale.)

The expected outcome is that the implementation should pass the related WPTs in transfering.https.any.js.

Comment 1

[pommicket]

Attachment: Bug 1994891 - Implement `transfer` for AudioDataInit r?aosmond

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1bd71e921991
https://hg.mozilla.org/integration/autoland/rev/778fdda19db7
Implement `transfer` for AudioDataInit r=aosmond

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ee6cbb5aad6
https://hg.mozilla.org/integration/autoland/rev/81db789ce6de
Revert "Bug 1994891 - Implement `transfer` for AudioDataInit r=aosmond" for causing Hazard failures at AudioData.cpp.

Comment 4

[Atila Butkovits]

Backed out for causing Hazard failures at AudioData.cpp.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/81db789ce6de5d2564c5a34ea97473fbb3f2e268

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=KO_2760lR-qbdYS_Q_4t8A.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2Cdebug%2Chazard-linux64-haz%2Fdebug%2Ch&revision=4c62aba10d9aea15348d85f759f38c572cc50606

Failure log: https://treeherder.mozilla.org/logviewer?job_id=534573560&repo=autoland&task=KO_2760lR-qbdYS_Q_4t8A.0&lineNumber=151887

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a946c644949e
https://hg.mozilla.org/integration/autoland/rev/ae4de1794ea6
Implement `transfer` for AudioDataInit r=aosmond

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ae4de1794ea6