1994918 - Double clicking over top or bottom border of a window to vertical maximize stopped working

Status: UNCONFIRMED

(Core :: Widget: Win32, defect)

Description

[csalsa]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:145.0) Gecko/20100101 Firefox/145.0

Steps to reproduce:

Move the mouse pointer to the top or bottom border of a window until the pointer turns into a double arrow, and double click/tap.

Actual results:

No change to window size

Expected results:

Window should have maximized vertically to screen but no change to horizontal width. Useful for very wide monitors.
This feature worked with previous versions of Firefox.

Comment 1

[csalsa]

Tested on MS-Windows 11 only.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[csalsa]

This is a Firefox regression on Windows. Not Android.
Windows keyboard shortcut still works (Windows + Shift + Up-Arrow) to vertically maximize a window
(Windows + Shift + Down-Arrow) to restore original window size and position

Comment 4

[Claude Gohier]

I confirm the issue on Windows 11.

Comment 5

[juraj.masiar]

Bisection result:
Bug 1947324 part 6 - avoid using Windows App SDK on opt-talos-xperf runs r=bobowen,perftest-reviewers,kshampur

On opt-talos-xperf, the Windows App SDK fails
calling DCompositionCreateDevice3() with ERROR_ACCESS_DENIED,
and the code assumes it is going to succeed so it proceeds to crash
deferencing null.

We haven't seen this crash anywhere else, and so I suspect this has
something to do with the way Firefox is being run there. So add a pref
to turn off using the Windows App SDK for just this test.

If this turns out to cause crashes in other situations, we should figure
out what the situation is and try to fix it.

Differential Revision: https://phabricator.services.mozilla.com/D267040

Comment 6

[juraj.masiar]

Could someone edit the "Regressed by" field and add there bug 1947324?
I don't have permissions for that.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

:gstoll, since you are the author of the regressor, bug 1947324, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 8

[Greg Stoll :gstoll]

Note that this double-clicking does work on Chrome and Edge, but it doesn't work on Notepad or Windows Explorer.

Comment 9

[juraj.masiar]

That's interesting, maybe it's also a bug? :)
I always thought this is an OS feature.
It definitely works with all 3rd party apps I can currently find on my PC, including alternatives to the mentioned ones: "Notepad++" and "Q-Dir the Quad Explorer" :).

Comment 10

[Greg Stoll :gstoll]

The bug says this, but just a note to myself: this does not work for the left/right sides of the window (nor does it in Chrome, etc.)

Comment 11

[Greg Stoll :gstoll]

My potential fix for bug 1993474 seems to fix this too. (removing WS_BORDER)