199500 - Crash in [@ nsHttpConnectionMgr::OnSocketEvent] if PSM is not installed

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[kurros (Wade Majors)]

When attempting to load http://www.lovepop.net/enter.html I get an immediate
crash in nsHttpConnectionMgr::OnSocketEvent. This is a CVS Trunk pull from
today. Platform is FreeBSD 5.0-CURRENT, moz is built with pthreads).

---
0x28d0bb4b in nsHttpConnectionMgr::OnSocketEvent(unsigned, unsigned, void*) (
    this=0x28a62fe9, type=3503345872, uparam=3503345872, vparam=0x8cdd900)
    at nsHttpConnectionMgr.cpp:842
842                 NS_RELEASE(conn);
(gdb) bt
#0  0x28d0bb4b in nsHttpConnectionMgr::OnSocketEvent(unsigned, unsigned, void*)
    (this=0x28a62fe9, type=3503345872, uparam=3503345872, vparam=0x8cdd900)
    at nsHttpConnectionMgr.cpp:842
#1  0x28cc8465 in nsSocketTransportService::ServiceEventQ() (this=0x814c800)
    at nsSocketTransportService2.cpp:300
#2  0x28cc928c in nsSocketTransportService::Run() (this=0x814c800)
    at nsSocketTransportService2.cpp:606
#3  0x28a13c54 in nsThread::Main(void*) (arg=0x8164be0) at nsCOMPtr.h:690
#4  0x2816b299 in PR_Select () from ./libnspr4.so
#5  0x2882c46e in _thread_start () from /usr/lib/libc_r.so.5
(gdb)

Comment 1

[kurros (Wade Majors)]

I just updated my Windows XP system and am not seeing it there, just under
FreeBSD5. Hopefully someone else can reproduce this. I clean/clobbered overnight
after I saw this and rebuilt so I think my tree is kosher.

Comment 2

[Darin Fisher]

*** This bug has been marked as a duplicate of 199492 ***

Comment 3

[kurros (Wade Majors)]

I am still seeing this even with the fix from 199492. Attaching an HTTP log.

Comment 4

[kurros (Wade Majors)]

Attachment: HTTP log of connection

Comment 5

[Darin Fisher]

this is for real.. it happens if PSM is not installed.  investigating...

Comment 6

[Darin Fisher]

Attachment: v1 patch

Comment 7

[Alec Flett]

Comment on attachment 118679 [details] [diff] [review]
v1 patch

r/sr=alecf

Comment 8

[Darin Fisher]

Comment on attachment 118679 [details] [diff] [review]
v1 patch

seeking drivers approval for 1.4 alpha.  this is another crash regression from
the NTLM landing.  thx!

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 118679 [details] [diff] [review]
v1 patch

a=dbaron, but shouldn't the comment say "sever" rather than "severe"?

Comment 10

[kurros (Wade Majors)]

Fixed on trunk

Comment 11

[Darin Fisher]

thx kurros!