1995058 - Update the timeouts of xpcshell tests

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, task)

Description

[Florian Quèze [:florian]]

All xpcshell tests currently timeout in 300s (5m) by default, unless requesttimeoutfactor is set in the manifest. We should have a much lower default timeout, and adjust the default timeout based on the job type (platform, opt vs debug, ...).

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1995058 - add support for setting the timeoutfactor per platform in xpcshell.yml, r=jmaher.

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1995058 - set xpcshell timeout factors per platform, r=jmaher.

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1995058 - remove existing requesttimeoutfactor annotations in xpcshell test manifests, r=jmaher.

Comment 4

[Florian Quèze [:florian]]

Attachment: Bug 1995058 - set requesttimeoutfactor annotations for xpcshell tests that exceed the new 30s default timeout, r=jmaher.

Comment 5

[Florian Quèze [:florian]]

Attachment: Bug 1995058 - set the default xpcshell test timeout to 30s, r=jmaher.

Comment 6

[Florian Quèze [:florian]]

Attachment: Bug 1995058 - document requesttimeoutfactor in the xpcshell test documentation, r=jmaher,standard8.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/90107538e289
https://hg.mozilla.org/integration/autoland/rev/4e72f200e3c7
add support for setting the timeoutfactor per platform in xpcshell.yml, r=jmaher,taskgraph-reviewers.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c5d27cd7ef06
https://hg.mozilla.org/integration/autoland/rev/a67329b92a15
Revert "Bug 1995058 - add support for setting the timeoutfactor per platform in xpcshell.yml, r=jmaher,taskgraph-reviewers." for causing gecko decions tasks failures.

Comment 9

[agoloman]

Backed out for causing gecko decions tasks failures.

• Backout link
• Push with failures
• Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c221107ad820
https://hg.mozilla.org/integration/autoland/rev/d671316067c6
add support for setting the timeoutfactor per platform in xpcshell.yml, r=jmaher,taskgraph-reviewers.
https://github.com/mozilla-firefox/firefox/commit/f67732d0a308
https://hg.mozilla.org/integration/autoland/rev/7b03d723a483
set xpcshell timeout factors per platform, r=jmaher.
https://github.com/mozilla-firefox/firefox/commit/c06f392aef6a
https://hg.mozilla.org/integration/autoland/rev/a5b433131296
remove existing requesttimeoutfactor annotations in xpcshell test manifests, r=jmaher,necko-reviewers,extension-reviewers,dom-storage-reviewers,janv,valentin,robwu.
https://github.com/mozilla-firefox/firefox/commit/ea144b096178
https://hg.mozilla.org/integration/autoland/rev/560c2aa14714
set requesttimeoutfactor annotations for xpcshell tests that exceed the new 30s default timeout, r=jmaher,necko-reviewers,extension-reviewers,dom-storage-reviewers,migration-reviewers,toolkit-telemetry-reviewers,sthompson,janv,valentin,robwu,janerik.
https://github.com/mozilla-firefox/firefox/commit/4ce73f1fabb1
https://hg.mozilla.org/integration/autoland/rev/e96d09168e55
set the default xpcshell test timeout to 30s, r=jmaher.
https://github.com/mozilla-firefox/firefox/commit/621b1c494173
https://hg.mozilla.org/integration/autoland/rev/1a990500e490
document requesttimeoutfactor in the xpcshell test documentation, r=jmaher,Standard8.

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d671316067c6
https://hg.mozilla.org/mozilla-central/rev/7b03d723a483
https://hg.mozilla.org/mozilla-central/rev/a5b433131296
https://hg.mozilla.org/mozilla-central/rev/560c2aa14714
https://hg.mozilla.org/mozilla-central/rev/e96d09168e55
https://hg.mozilla.org/mozilla-central/rev/1a990500e490

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: Bug 1995058 - increase the requesttimeoutfactor for slow test_Region_geocoding.js. r=florian

The test timing out on Thunderbird CI, and is super slow locally as well, takes almost 90s for me.