1995368 - Fix saved group tab storage removal in backups

Status: RESOLVED FIXED

(Firefox :: Profile Backup, defect, P1)

Description

[David Parks [:handyman]]

From @sthompson in the review for bug 1994513, this

group.tabs.forEach(tab => delete tab.storage);

should be this:

group.tabs.forEach(tab => delete tab.state.storage);

SavedGroups use a separate state object, similar to _closedTabs.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1994513

Comment 2

[David Parks [:handyman]]

Attachment: Bug 1995368: Fix saved group tab storage removal in backups r=#backup-reviewers!

From the review for bug 1994513, savedGroups tab entries contain a state
object, the way _closedTabs does (but tabs does not).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/20a23bdc4250
https://hg.mozilla.org/integration/autoland/rev/da12b6792882
Fix saved group tab storage removal in backups r=fchasen

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/da12b6792882

Comment 5

[David Parks [:handyman]]

Comment on attachment 9521169 [details]
Bug 1995368: Fix saved group tab storage removal in backups r=#backup-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: This is part of the planned FxBackup uplifts. It was supposed to be part of the uplift in bug 1995365, but that was done earlier than planned -- while this patch was still awaiting review.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1995365
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Removes saved group storage from backups. They are not backed up with e.g. sync, so this is expected to improve compatibility.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/4c1b3a2789bf
https://hg.mozilla.org/releases/mozilla-beta/rev/792eb4fd13f6