1995403 - Improve Translated Reverse-Script-Direction Page Layout for Tables

Status: VERIFIED FIXED

(Firefox :: Translations, enhancement)

Description

[Erik Nordin [:nordzilla]]

Attachment: table-test.html

Description

In Bug 1975487 we made some improvements to the page layout when translating between LTR/RTL languages.

After soliciting more feedback from RTL-language spakers, one case that could specifically be handled better are <table> tags and their content.

With the implementation from Bug 1975487, the text gets the proper direction, but the table itself does not.

We should add some special-case logic that will check whether the text is within a table, and flip the entire table direction appropriately.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1995403 - Apply translated script direction to <table> r=#translations-reviewers!

This patch adds some special-case logic that ensures <table>
elements and relevant childen are flipped to the target script
direction when translating between LTR/RTL pages.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5ab9b6db2133
https://hg.mozilla.org/integration/autoland/rev/37ee38708c0d
Apply translated script direction to <table> r=translations-reviewers,gregtatum

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/37ee38708c0d

Comment 4

[Erik Nordin [:nordzilla]]

Steps to Verify

1. Open the test page attached to this bug.
2. Note that the page is right-aligned as written in Arabic.
3. Translate the page from Arabic to English.

Expected Behavior

The alignments of the table cells and columns become left adjusted.

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Similar to Bug 1975487, which I uplifted earlier this week. This is one more low-risk, but high-impact change to Translations quality of life when translating between LTR and RTL languages (e.g. English to Arabic). This will be my final uplift of this kind for this cycle, since we are exiting early beta soon.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps to verify are in Bug 1995403, comment 4.
• Risk associated with taking this patch: low
• Explanation of risk level: This is once again a very low-risk change that only modifies HTML element attributes and is well covered by automated tests.
• String changes made/needed: None
• Is Android affected?: yes

Comment 6

[Erik Nordin [:nordzilla]]

Attachment: Bug 1995403 - Apply translated script direction to <table> r=#translations-reviewers!

This patch adds some special-case logic that ensures <table>
elements and relevant childen are flipped to the target script
direction when translating between LTR/RTL pages.

Original Revision: https://phabricator.services.mozilla.com/D269294

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 146.0a1 (20251020161546) on Windows 11. Translating the test page will show the alignments of the table cells and columns on the right.
The issue is verified fixed with Firefox 146.0a1 (2025-10-23) on Windows 11, macOS 26, and Ubuntu 24. The table cells are displayed on the left side.

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/8cbe70fc00e4
https://hg.mozilla.org/releases/mozilla-beta/rev/74cb14631801

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

The issue is verified fixed with Firefox 145.0b6 on Windows 11, macOS 26, and Ubuntu 24. The table cells are displayed on the left side.