1995435 - Add profile age check to TOU_TARGETING_ANDROID_NOT_ACCEPTED_AND_NO_SPONSORED_OPT_OUTS advanced targeting

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, task, P1)

Description

[Chris Peterson [:cpeterson]]

We don't want to enroll users before they have a chance to accept the ToU during new user onboarding, so add a check for profile age > 28 days ({PROFILE28DAYS}):

https://github.com/mozilla/experimenter/blob/b5b1403dc2684b258055e22f69839bb8394e77a4/experimenter/experimenter/targeting/constants.py#L32

to our TOU_TARGETING_ANDROID_NOT_ACCEPTED_AND_NO_SPONSORED_OPT_OUTS advanced targeting config:

https://github.com/mozilla/experimenter/blob/b5b1403dc2684b258055e22f69839bb8394e77a4/experimenter/experimenter/targeting/constants.py#L2528-L2543

Comment 1

[twhite]

Chris, should we also include updating TOU_TARGETING_ANDROID_NOT_ACCEPTED to include the 28 day check?

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to twhite from comment #1)

Chris, should we also include updating TOU_TARGETING_ANDROID_NOT_ACCEPTED to include the 28 day check?

Good catch. There's no need to update that targeting since none of our future experiments plan to use TOU_TARGETING_ANDROID_NOT_ACCEPTED. (Those experiments will use the 0/1/2 points targeting.) You can remove it in bug 1995564 as you noted there. :)

Comment 3

[Chris Peterson [:cpeterson]]

Tom fixed this issue in bug 1994130.

Comment 4

[Chris Peterson [:cpeterson]]

This issue was not actually a duplicate of bug 1994130. This issue was fixed in https://github.com/mozilla/experimenter/pull/13737