1995511 - Sidebar settings cog is now displayed alongside the tools in horizontal tabs instead of being anchored at the bottom

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Stuart Colville [:muffinresearch]]

Via a report on sumo https://support.mozilla.org/questions/1542350 the sidebar settings icon is now next to the tools rather than being anchored to the bottom of the sidebar.

We should also consider adding a test to cover this case as part of the fix to guard against a future recurrence.

Reproducible in current release (144).

Comment 1

[:Gijs (away/busy until Mar 10)]

(In reply to Stuart Colville [:muffinresearch] from comment #0)

We should also consider adding a test to cover this case as part of the fix to guard against a future recurrence.

We don't really have good infrastructure for doing visual tests, unfortunately.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:kcochrane, since you are the author of the regressor, bug 1986275, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Donal Meehan [:dmeehan]]

The planned Fx144 dot release build ships next week. We could include a fix if we have a safe patch with an uplift request by 20205-10-24.

Comment 4

[Kelly Cochrane [:kcochrane]]

Setting this as P1/S4 just because it's a quick fix and we can fix in the current release cycle (and potentially the Fx144 dot release build).

Comment 5

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1995511 - Ensure 'customize sidebar' button displays at the bottom of the sidebar when horizontal tabs are enabled

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/37607b8dd185
https://hg.mozilla.org/integration/autoland/rev/6263c1e70eb5
Ensure 'customize sidebar' button displays at the bottom of the sidebar when horizontal tabs are enabled r=sclements

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6263c1e70eb5

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kcochrane, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox145 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Donal Meehan [:dmeehan]]

:kcochrane, to add to Comment 8, we could also take a release uplift request too if you want.
The deadline for the Fx144 planned dot release uplift requests is eod Friday 2025-10-24.

Comment 10

[Kelly Cochrane [:kcochrane]]

Oh woops I thought I already did request an uplift for release.

Comment 11

[Kelly Cochrane [:kcochrane]]

Comment on attachment 9521366 [details]
Bug 1995511 - Ensure 'customize sidebar' button displays at the bottom of the sidebar when horizontal tabs are enabled

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Customize sidebar button may be aligned at the top of the sidebar when horizontal tabs are enabled rather than at the bottom.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Enable the new sidebar (sidebar.revamp pref set to true) and keep horizontal tabs enabled. Ensure that after this update, the tools/extension buttons remain at the top of the sidebar while the customize sidebar button (gear icon) is at the bottom.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One line css change
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox Nightly 146.0a1 (19.10.2025) on macOS 10.15 and on Windows 11.
I can confirm this issue is fixed, I verified using latest Nightly Firefox 146.0a1 (22.10.2025) on Windows 11, Ubuntu 24 and macOS 10.15.

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/b5fb617997f6
https://hg.mozilla.org/releases/mozilla-beta/rev/e605971a0391

Comment 14

[Donal Meehan [:dmeehan]]

Comment on attachment 9521366 [details]
Bug 1995511 - Ensure 'customize sidebar' button displays at the bottom of the sidebar when horizontal tabs are enabled

Approved for 144.0.2

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e03ada046cbb
https://hg.mozilla.org/releases/mozilla-release/rev/f9dfe9b0a296

Comment 16

[Timea Zsoldos [:tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified on Firefox 145.0b7 and on Firefox 144.0.2 on Windows 11, Ubuntu 22 and macOS 10.15.