1995522 - Use clang-include-cleaner to prevent inclusion of unused mfbt headers

Status: RESOLVED FIXED

(Core :: MFBT, task)

Description

[[:sergesanspaille]]

clang-include-cleaner has several option that make it a good candidate for an incremental adoption of an automated include cleaner:

• one can limit the analysis to a few headers
• one can limit the analysis to include removal

I've been cleaning mfbt header inclusion recently, I think we're good to start small with that tool with a focus on "no unused mfbt header inclusion"

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::MFBT' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[[:sergesanspaille]]

Attachment: Bug 1995522 - New Linter - ensure we don't include unnecessary mfbt headers r=standard8!

Comment 3

[[:sergesanspaille]]

Attachment: Bug 1995522 - Cleanup remaining unused mfbt includes r=emilio!

Those are the remaining parts required before we land the new mhbt
header inclusion linter

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f7628a0557f7
https://hg.mozilla.org/integration/autoland/rev/1f79153b0370
New Linter - ensure we don't include unnecessary mfbt headers r=glandium,linter-reviewers,ahal

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4c7ef1719715
https://hg.mozilla.org/integration/autoland/rev/b4f0df728692
Revert "Bug 1995522 - New Linter - ensure we don't include unnecessary mfbt headers r=glandium,linter-reviewers,ahal" for causing linting failures @MemMapSnapshot.h.

Comment 6

[agoloman]

Backed out for causing linting failures @MemMapSnapshot.h.

• Backout link
• Push with failures
• Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d0eaaff18d27
https://hg.mozilla.org/integration/autoland/rev/3ebfe1ca67d0
Cleanup remaining unused mfbt includes r=emilio,necko-reviewers,media-playback-reviewers,webrtc-reviewers,profiler-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,layout-reviewers,dom-worker-reviewers,emz,mstange,TYLin,alwu,pehrsons,dom-storage-reviewers,valentin,jari,jwatt,hsingh,edenchuang,janv

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3f4162216343
https://hg.mozilla.org/integration/autoland/rev/5755734bbadb
New Linter - ensure we don't include unnecessary mfbt headers r=glandium,linter-reviewers,ahal

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3ebfe1ca67d0
https://hg.mozilla.org/mozilla-central/rev/5755734bbadb

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/17287b2ae8ef
https://hg.mozilla.org/integration/autoland/rev/5ed2a8d8d0c1
Revert "Bug 1995522 - Cleanup remaining unused mfbt includes r=emilio,necko-reviewers,media-playback-reviewers,webrtc-reviewers,profiler-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,layout-reviewers,dom-worker-reviewers,emz,mstange,TYLin,alwu,pehrsons,dom-storage-reviewers,valentin,jari,jwatt,hsingh,edenchuang,janv" for causing conflict on reverting Bug 1998267

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dada95df6235
https://hg.mozilla.org/integration/autoland/rev/8f16036f9483
Revert "Bug 1995522 - New Linter - ensure we don't include unnecessary mfbt headers r=glandium,linter-reviewers,ahal" in addition to Bug 1995522

Comment 12

[Cristina Horotan [:chorotan]]

Backed out here https://hg.mozilla.org/integration/autoland/rev/5ed2a8d8d0c1872bc50d5323b87af317827dfbec and https://hg.mozilla.org/integration/autoland/rev/8f16036f9483a48357d16a63fdec8674a2520a9d for causing build bustages when https://bugzilla.mozilla.org/show_bug.cgi?id=1998267 was backed out.

The backout wasn't caused by any issue you introduced, but by a dependency problem, sorry about that.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5507f1c19ac1
https://hg.mozilla.org/integration/autoland/rev/bf315e222e06
Cleanup remaining unused mfbt includes r=emilio,necko-reviewers,media-playback-reviewers,webrtc-reviewers,profiler-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,layout-reviewers,dom-worker-reviewers,emz,mstange,TYLin,alwu,pehrsons,dom-storage-reviewers,valentin,jari,jwatt,hsingh,edenchuang,janv
https://github.com/mozilla-firefox/firefox/commit/ae90c334421a
https://hg.mozilla.org/integration/autoland/rev/2a821d61fc12
New Linter - ensure we don't include unnecessary mfbt headers r=glandium,linter-reviewers,ahal

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bf315e222e06
https://hg.mozilla.org/mozilla-central/rev/2a821d61fc12