1995543 - Add new context menu options for adding and removing a split view to/from a tab group

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser: Split View, task)

Description

[Kelly Cochrane [:kcochrane]]

When adding or removing a split view to or from a tab group, we should show a different context menu option that is specific to split views. To new option to add a split view to a tab group should read Add Split View to Group. The option to remove a split view from a tab group should read Remove from Group similar to what we use for removing a tab from a group.

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1995543 - Add new context menu options for adding/removing split views to/from tab groups

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fe2b6b183913
https://hg.mozilla.org/integration/autoland/rev/4e05457a20bc
Add new context menu options for adding/removing split views to/from tab groups r=tabbrowser-reviewers,sthompson,fluent-reviewers,jsudiaman,bolsson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3fff33da5b78
https://hg.mozilla.org/integration/autoland/rev/0e9c12e4f4e1
Revert "Bug 1995543 - Add new context menu options for adding/removing split views to/from tab groups r=tabbrowser-reviewers,sthompson,fluent-reviewers,jsudiaman,bolsson" for causing failures at browser_tab_preview.js.

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_tab_preview.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/0e9c12e4f4e115a58e8b6e85e6507637735a066b

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=PGqURctGTGa8GovDVM12fg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2f98f3ed37e6611d0a71ed76d3f8a7884509c23c

Failure log: https://treeherder.mozilla.org/logviewer?job_id=536337409&repo=autoland&task=PGqURctGTGa8GovDVM12fg.0&lineNumber=45571

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d4b8519d8c62
https://hg.mozilla.org/integration/autoland/rev/ac9875911804
Add new context menu options for adding/removing split views to/from tab groups r=tabbrowser-reviewers,sthompson,fluent-reviewers,jsudiaman,bolsson

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ac9875911804

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! I have verified the following on Windows 11, macOS 26 and Ubuntu 24:

• The Add Split View to Group context menu option is correctly working on an open and a new group by adding the selected Split View to that group. It seems that this is not working correctly when using it on a closed group for which I filed bug 2001551.
• The Remove from Group context menu correctly removes the Split View from the group

However, I noticed the following, and I want to confirm this is expected:

1. In the Spec Doc, the remove option is called Remove Split View from Group, not Remove from Group when used on a Split View.
2. If we select a normal tab and a view from a Split View while they are in a Group and then using the Remove from Group option, only the selected View and the tab will be removed from that group. However, if we use the Add Tabs to Group option on a normal tab and a View, it will add the entire Split View and the normal tab to that group. This is not related to this issue, as the same behavior occurs on 146.
3. The Add Split View to Group context menu option is also displayed inside the List all Tabs, even if the Split View is displayed as normal tabs.

Thank you!

Comment 8

[Kelly Cochrane [:kcochrane]]

(In reply to Alexandru Trif, Desktop Test Engineering [:atrif] from comment #7)

However, I noticed the following, and I want to confirm this is expected:

1. In the Spec Doc, the remove option is called Remove Split View from Group, not Remove from Group when used on a Split View.
2. If we select a normal tab and a view from a Split View while they are in a Group and then using the Remove from Group option, only the selected View and the tab will be removed from that group. However, if we use the Add Tabs to Group option on a normal tab and a View, it will add the entire Split View and the normal tab to that group. This is not related to this issue, as the same behavior occurs on 146.
3. The Add Split View to Group context menu option is also displayed inside the List all Tabs, even if the Split View is displayed as normal tabs.

Thank you!

1. Ah yeah sorry we had a discussion about this in Slack with UX/Product and we decided to re-use the existing "Remove from Group" option for split views as it wasn't tab-specific. I guess the specs haven't been updated to reflect that just yet.
2. Hrm let me ask about this next week and I'll write it up separately if needed
3. Ditto here, I'll check on this, but I'd image we might not want to show that option there. I can write that up separately if needed.

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Kelly Cochrane [:kcochrane] from comment #8)

(In reply to Alexandru Trif, Desktop Test Engineering [:atrif] from comment #7)

However, I noticed the following, and I want to confirm this is expected:

1. In the Spec Doc, the remove option is called Remove Split View from Group, not Remove from Group when used on a Split View.
2. If we select a normal tab and a view from a Split View while they are in a Group and then using the Remove from Group option, only the selected View and the tab will be removed from that group. However, if we use the Add Tabs to Group option on a normal tab and a View, it will add the entire Split View and the normal tab to that group. This is not related to this issue, as the same behavior occurs on 146.
3. The Add Split View to Group context menu option is also displayed inside the List all Tabs, even if the Split View is displayed as normal tabs.

Thank you!

1. Ah yeah sorry we had a discussion about this in Slack with UX/Product and we decided to re-use the existing "Remove from Group" option for split views as it wasn't tab-specific. I guess the specs haven't been updated to reflect that just yet.
2. Hrm let me ask about this next week and I'll write it up separately if needed
3. Ditto here, I'll check on this, but I'd image we might not want to show that option there. I can write that up separately if needed.

Hey Kelly! Sorry for the late response. Should I file new issues for 2 and 3? Thank you!

Comment 10

[Kelly Cochrane [:kcochrane]]

For #2, UX/Product are still discussing this, but I've just pinged to see if there are any updates.
For #3, I've filed bug 2002242 last week and set it to P3 per :asafko's request.