Closed Bug 1995567 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 55573 - [anchor] Don't trigger a relayout unless the current option overflows.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
146 Branch
Tracking Flags:
Tracking Status
firefox146 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Attachments

(5 files)

Notable wpt changes
104.24 KB, text/plain
Details
Notable wpt changes
104.24 KB, text/plain
Details
Notable wpt changes
104.24 KB, text/plain
Details
Notable wpt changes
104.24 KB, text/plain
Details
Notable wpt changes
104.24 KB, text/plain
Details

Sync web-platform-tests PR 55573 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/55573
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[anchor] Don't trigger a relayout unless the current option overflows.

Previously we triggered relayout when any option became valid - even if
we'd prefer the last-successful option. As a result we'd relayout the
last-successful option, potentially causing it to change size.

Now in non_overflowing_scroll_ranges we either store:

  • A single range for the successful option (so that we can invalidate
    when it doesn't have any space anymore).
  • A list of all ranges (who all don't fit - so that we can invalidate
    when one of them does have space).

All behaviour changes should be behind the CSSAnchorUpdate flag.

Bug: 438515315
Change-Id: Icb49c2b6b9f3c08aa8c6274b65576f59b64776b4

Reviewed-on: https://chromium-review.googlesource.com/7063463
WPT-Export-Revision: 1593004f1ee2123126b95d48070fedb542e84cb2

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Attached file Notable wpt changes —
# CI Results Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 399 tests ## Status Summary ### Firefox `OK` : 227 `PASS`: 27[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 12800[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 12867[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 12869[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] `FAIL`: 1[GitHub] 684[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 758[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 759[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 761[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] ### Chrome `PASS`: 1 ### Safari `PASS`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=24ebb2013ac23a93cd90fb5ca61abefb24f96a36) [GitHub PR Head](https://wpt.fyi/results/?sha=6561e8feb21f20b1e7b7714e986cae2f84aecf2f&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=6561e8feb21f20b1e7b7714e986cae2f84aecf2f&label=pr_base) ## Details ### Firefox-only Failures * [/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html](https://wpt.live/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html) [[wpt.fyi](https://wpt.fyi/results/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html)]: `FAIL` (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 399 tests ## Status Summary ### Firefox `OK` : 227 `PASS`: 27[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 12800[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 12867[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 12869[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] `FAIL`: 1[GitHub] 684[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 758[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 759[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 761[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] ### Chrome `PASS`: 1 ### Safari `PASS`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=24ebb2013ac23a93cd90fb5ca61abefb24f96a36) [GitHub PR Head](https://wpt.fyi/results/?sha=6561e8feb21f20b1e7b7714e986cae2f84aecf2f&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=6561e8feb21f20b1e7b7714e986cae2f84aecf2f&label=pr_base) ## Details ### Firefox-only Failures * [/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html](https://wpt.live/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html) [[wpt.fyi](https://wpt.fyi/results/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html)]: `FAIL` (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 399 tests ## Status Summary ### Firefox `OK` : 227 `PASS`: 27[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 12800[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 12867[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 12869[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] `FAIL`: 1[GitHub] 684[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 758[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 759[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 761[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] ### Chrome `PASS`: 1 ### Safari `PASS`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=24ebb2013ac23a93cd90fb5ca61abefb24f96a36) [GitHub PR Head](https://wpt.fyi/results/?sha=6561e8feb21f20b1e7b7714e986cae2f84aecf2f&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=6561e8feb21f20b1e7b7714e986cae2f84aecf2f&label=pr_base) ## Details ### Firefox-only Failures * [/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html](https://wpt.live/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html) [[wpt.fyi](https://wpt.fyi/results/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html)]: `FAIL` (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 399 tests ## Status Summary ### Firefox `OK` : 227 `PASS`: 27[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 12800[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 12867[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 12869[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] `FAIL`: 1[GitHub] 684[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 758[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 759[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 761[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] ### Chrome `PASS`: 1 ### Safari `PASS`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=24ebb2013ac23a93cd90fb5ca61abefb24f96a36) [GitHub PR Head](https://wpt.fyi/results/?sha=6561e8feb21f20b1e7b7714e986cae2f84aecf2f&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=6561e8feb21f20b1e7b7714e986cae2f84aecf2f&label=pr_base) ## Details ### Firefox-only Failures * [/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html](https://wpt.live/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html) [[wpt.fyi](https://wpt.fyi/results/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html)]: `FAIL` (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 399 tests ## Status Summary ### Firefox `OK` : 227 `PASS`: 27[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 12800[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 12867[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 12869[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] `FAIL`: 1[GitHub] 684[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 758[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 759[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 761[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] ### Chrome `PASS`: 1 ### Safari `PASS`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=24ebb2013ac23a93cd90fb5ca61abefb24f96a36) [GitHub PR Head](https://wpt.fyi/results/?sha=6561e8feb21f20b1e7b7714e986cae2f84aecf2f&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=6561e8feb21f20b1e7b7714e986cae2f84aecf2f&label=pr_base) ## Details ### Firefox-only Failures * [/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html](https://wpt.live/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html) [[wpt.fyi](https://wpt.fyi/results/css/css-anchor-position/anchor-scroll-position-try-015.tentative.html)]: `FAIL` (See attachment for full changes)

https://hg.mozilla.org/mozilla-central/rev/76a5d241707a
https://hg.mozilla.org/mozilla-central/rev/dc26dfcef94d

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox146: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: