1995575 - Use at-start allocations for lowerForFPU for {mips,loong,riscv}64

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[André Bargull [:anba]]

lowerForFPU can trivially be changed to use at-start allocations for {mips,loong,riscv}64, because no additional codegen changes are needed. Updating lowerForALU requires some codegen changes, so it will need to happen in a different bug.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1995575 - Part 1: Use at-start allocations for lowerForFPU on {mips,loong,riscv}64. r=#spidermonkey-reviewers!

No additional codegen changes are needed for FPU instructions.

Drive-by change:

• Change src to input in declaration to match name in method definition.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1995575 - Part 2: Use simple define calls in lowerFor{ALU,FPU}. r=#spidermonkey-reviewers!

Calling the two-argument define method has the same effect.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1995575 - Part 3: Remove unused template from lowerForFPU method. r=#spidermonkey-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c31b8aecbf4e
https://hg.mozilla.org/integration/autoland/rev/38653eff9816
Part 1: Use at-start allocations for lowerForFPU on {mips,loong,riscv}64. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/768b8aa8ed02
https://hg.mozilla.org/integration/autoland/rev/af0879673973
Part 2: Use simple define calls in lowerFor{ALU,FPU}. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/71353cfaee71
https://hg.mozilla.org/integration/autoland/rev/07d2b9b56529
Part 3: Remove unused template from lowerForFPU method. r=spidermonkey-reviewers,jandem

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/38653eff9816
https://hg.mozilla.org/mozilla-central/rev/af0879673973
https://hg.mozilla.org/mozilla-central/rev/07d2b9b56529