1995618 - Pass the links present on the page as a list in the PageExtractor

Status: RESOLVED FIXED

(Core :: Machine Learning: On Device, enhancement, P2)

Description

[Greg Tatum [:gregtatum]]

The text content is extracted from the page, but we don't grab the links explicitly. We should do this, maybe as an optional piece of behavior. We'll need to specify the format, but maybe just doing things in markdown would make sense.

Here is an example test:

Added to:
toolkit/components/pageextractor/tests/browser/browser_dom_extractor.js

add_task(async function test_dom_extractor_links() {
  const { actor, cleanup } = await html`
    <article>
      <h1>Example of Links</h1>
      <ul>
        <li>Here is the <a href="./example-1.html">First link</a></li>
        <li>
          Now this is an <a href="https://example.com/link">external link</a>
        </li>
      </ul>
    </article>
  `;

  const { text, links } = await actor.getText();

  is(
    text,
    "Example of Links\n" +
      "Here is the [First link](https://localhost:7372/example-1.html)\n" +
      "Now this is an [external link](https://example.com/link)",
  );
  Assert.deepEqual(
    links,
    ["./example-1.html", "https://example.com/link"]
  );

  return cleanup();
});

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit BugBot documentation.

Comment 2

[Taimur]

Attachment: Bug 1995618 - Pass page links as list to PageExtractor r=gregtatum

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5433b8bb8f2d
https://hg.mozilla.org/integration/autoland/rev/f145e47d11fe
Pass page links as list to PageExtractor r=ai-ondevice-reviewers,gregtatum

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/efbcc321b8d1
https://hg.mozilla.org/integration/autoland/rev/891741892645
Revert "Bug 1995618 - Pass page links as list to PageExtractor r=ai-ondevice-reviewers,gregtatum" for causing bc failures on browser_dom_extractor.js.

Comment 5

[Iulian Moraru]

Revert for causing bc failures on browser_dom_extractor.js and browser_get_page_content.js.

• Push with failures

• Failure log for failures on browser_dom_extractor.js

• Failure log for failures on browser_get_page_content.js

• Backout link

Comment 6

[Taimur]

Attachment: Bug 1995618 - Update GetPageContent to use new links format r=gregtatum

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6686036b198b
https://hg.mozilla.org/integration/autoland/rev/0a795970d1b3
Pass page links as list to PageExtractor r=ai-ondevice-reviewers,gregtatum
https://github.com/mozilla-firefox/firefox/commit/98c32ffaf198
https://hg.mozilla.org/integration/autoland/rev/e4d57db08628
Update GetPageContent to use new links format r=gregtatum,ai-ondevice-reviewers

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0a795970d1b3
https://hg.mozilla.org/mozilla-central/rev/e4d57db08628