199567 - -disable-oji breaks NPAPI funtion table order

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Peter Lubczynski]

The recent checkin to npupp.h to adds a bunch of #ifdef OJI's for diabling OJI
but breaks the order of the following setValue and getValue functions. Plugin
vendors that forget to define OJI will break.

Comment 1

[hacker formerly known as [e-mail]]

Breaks the ordering in what sense?  

Comment 2

[Simon Fraser [no longer active]]

The offsets of getvalue and setvalue, and everything after getJavaPeer, change
depending on whether OJI is defined. The layout of these tables *has* to remain
fixed, irrespective of the OJI setting.

Comment 3

[hacker formerly known as [e-mail]]

Attachment: Revert npupp.h changes

Comment 4

[Peter Lubczynski]

Comment on attachment 118730 [details] [diff] [review]
Revert npupp.h changes

requesting approval for 1.4a: this change is needed for plugin vendor to
develop compatible plugins with this header file

Comment 5

[Peter Lubczynski]

Comment on attachment 118730 [details] [diff] [review]
Revert npupp.h changes

requesting approval for 1.4a: this change is needed for plugin vendor to
develop compatible plugins with this header file

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 118730 [details] [diff] [review]
Revert npupp.h changes

a=asa (on behalf of drivers) for checkin to 1.4a but time is short so please
get this landed ASAP. Thanks.

Comment 7

[hacker formerly known as [e-mail]]

Patch has been checked in.

Comment 8

[bmartin]

Marking Verified Fixed

I verified the changes specified in the attached patch were checked in on 3/31/03
CVS Log for npupp.h :
http://bonsai.mozilla.org/cvslog.cgi?file=/mozilla/modules/plugin/base/public/npupp.h&root=/cvsroot

Rev details:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=npupp.h&root=/cvsroot&subdir=/mozilla/modules/plugin/base/public&command=DIFF_FRAMESET&rev1=3.13&rev2=3.14