1995818 - Add session restore support for splitview tabs

Status: VERIFIED FIXED

(Firefox :: Session Restore, enhancement, P1)

Description

[Sarah Clements [:sclements]]

Behavior is outlined in the blueprint .

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1995818 - Add Session Store support for Split View r=#sessionstore-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/88146a3e5bc6
https://hg.mozilla.org/integration/autoland/rev/b1232b240fcf
Add Session Store support for Split View r=sessionstore-reviewers,tabbrowser-reviewers,sthompson,sclements

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8e03c42067cc
https://hg.mozilla.org/integration/autoland/rev/1882d49daf54
Revert "Bug 1995818 - Add Session Store support for Split View r=sessionstore-reviewers,tabbrowser-reviewers,sthompson,sclements" for causing marionette test failures on test_splitview_restore.py.

Comment 5

[Iulian Moraru]

Revert for causing marionette test failures on test_splitview_restore.py.

• Push with failures

• Failure log

• Backout link

Comment 6

[Sandor Molnar[:smolnar]]

also these bc failures

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fe217f27dfed
https://hg.mozilla.org/integration/autoland/rev/6f7aafb2d39e
Add Session Store support for Split View r=sessionstore-reviewers,tabbrowser-reviewers,sthompson,sclements

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6f7aafb2d39e

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! We have tested the following with Firefox 149.0a1 (2026-01-27) on Windows 11, macOS 26 aarch and Ubuntu 24:

• Split Views that are inside/outside groups are correctly preserved after an update, crash, or restart - note that bug 2012661 was encountered
• Split Views that are inside/outside groups are correctly restored when using the restore session enabled by default or manually restoring
• Split Views that are inside/outside groups are correctly restored across windows when using the Recently closed windows option
• Split Views are correctly preserved when switching between multiple profiles
• Split Views are not restored after closing the tabs separately and then using the Recently closed tabs option or Ctrl+ Shift+ T keyboard shortcut
• Split Views are restored while was in a group that has been deleted and restored via the Recently closed tabs option or Ctrl+ Shift+ T keyboard shortcut
• Split View are restore while was in a group that has been closed and then restored via List all tabs menu or Ctrl+ Shift+ T keyboard shortcut

Do you think there is anything else that should be tested?

Also, from what I saw inside the Blueprint document, the last two implementations (restored Split Views inside a group) were not planned for V1, but they have been landed. I believe this is fine, but I’d like to confirm. Thank you!

Comment 10

[Nikki Sharpley (:nikkis) (she/her)]

Thanks Alexandru for the thorough testing! The last two implementations regarding tab groups are fine to include. They came as a bonus side effect to this patch.

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Nikki Sharpley (:nikkis) (she/her) from comment #10)

Thanks Alexandru for the thorough testing! The last two implementations regarding tab groups are fine to include. They came as a bonus side effect to this patch.

Thank you! Closing this.