1995821 - [graph] Add manual configuration of Exchange sub-protocol

Status: REOPENED

(MailNews Core :: Networking: Exchange, task, P2)

Description

[Eleanor Dicharry]

Add a configuration option that will enable the use of EWS or Graph API by the existing EWS implementation. Allow the manual configuration of the API endpoint to use when Graph is selected. The ability to do this should be hidden behind a pref that enables/disables the option to use Graph API for Exchange.

Comment 1

[Ben Bucksch (:BenB)]

We've been through this with Owl, which supports 3 Exchange protocols, and eventually it's easier to keep these protocols clearly separate. It makes a whole lot simpler later on:

• Server type implementation
• Account initialization on startup
• Manual config
• Automatic config using AutoConfig.

Otherwise, you'll need to add extra code and special cases everywhere. But when they are separate protocols, it just works out of the box and you just need to add an extra protocol entry.

In the AutoConfig spec, the Graph and EWS protocols are expressed as separate protocols as well, see protocol type definition, XML example, and real-world Office365 example.

In case it helps your decision: Both EWS and Graph protocols are not limited to Microsoft Exchange/Office365 servers, but a number of other mail servers support one or both of them, e.g. Zimbra and Amazon WorkMail support EWS, and Kopano supports Graph and EWS. So, arguably, both are separate protocols in their own right.

Please treat Graph as a top-level protocol in Thunderbird, on the same level as IMAP, POP3 and EWS, not as a sub-form below EWS. Specifically, the "server type" should say "graph", not "ews".

Comment 2

[Ben Bucksch (:BenB)]

As a side effect, keeping the server type implementations separate will force a cleaner API design as well, which makes the addition of new protocols easier. If you share code between EWS and Graph with normal programming techniques (crates, libraries, subclasses, functions, whatever fits), which will then also benefit future protocol implementations.

Comment 3

[Eleanor Dicharry]

Attachment: Bug 1995821 - Add new rust crate for ews/graph shared components. r=#thunderbird-back-end-reviewers

Comment 4

[Eleanor Dicharry]

Attachment: WIP: Bug 1995821 - Enable manual configuration of Graph protocol.

Comment 5

[Eleanor Dicharry]

Attachment: Bug 1995821 - Implement Graph client initialization. r=#thunderbird-back-end-reviewers

This commit also refactors the Exchange auth implementation into the shared
protocol crate for reuse across Graph and EWS.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c10366f3385d
Add new rust crate for ews/graph shared components. r=jtracey

Comment 7

[Eleanor Dicharry]

Forgot to mark this as leave-open

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/320f7f6618b2
Implement Graph client initialization. r=jtracey