1995928 - [Backup Onboarding] The spotlight is closed if pressing the “Enter” key when the Backup path field is focused

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: close spotlight enter path.mp4

[Affected versions]:

• Firefox Nightly 146.0a1 (Build ID: 20251020161546)

[Affected Platforms]:

• Windows 10 x64

[Prerequisites]:

• Have Firefox Nightly 146 installed.
• Make sure you meet the following targeting criteria:
  -> Have a Windows 10 machine
  -> The os.windowsBuildNumber is <= 19045
  -> Launch a legacy/classic Firefox profile
  -> Backup is turned off and has never been enabled before
  -> Don’t be signed in to a Mozilla Account
  -> FxA is enabled
  -> The notification has never been seen
  -> Don’t have SelectableProfiles
  -> Don’t have ActiveEnterprisePolicies
  -> Have backupArchiveEnabled
  -> The browser.backup.scheduled.user-disabled pref is false
  -> The browser.backup.scheduled.enabled pref is false
  -> The browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features pref is true
  -> Is not a MajorUpgrade
  -> It doesn’t show the DefaultPrompt
  -> It doesn’t show activeNotifications
  -> Have at least one previous browsing session.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a new tab page.
3. Click the “Select” button from the “Back up to PC” card.
4. Click the “Select” button of any of the “Easy setup” or “All data” cards.
5. Click inside the Backup path field.
6. Press the “Enter” key and observe the behavior.

[Expected result]:

• Nothing happens OR the OS folder picker is open.

[Actual result]:

• The spotlight is closed.

[Notes]:

• Attached is a screen recording with the issue.

Comment 1

[Sarah Chung [:sachung]]

Attachment: Bug 1995928 - Prevents spotlight from closing if enter is pressed while file path is focused

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/744fabac3f89
https://hg.mozilla.org/integration/autoland/rev/b043ae389013
Prevents spotlight from closing if enter is pressed while file path is focused r=kpatenio,emcminn

Comment 3

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Users eligible for the Fx Backup opt-in message will unintentionally close the spotlight if they press enter while the readonly backup file path field is focused.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This change adds an event listener that will only act on the enter key for only two specific input fields in the backup component.
• String changes made/needed: No
• Is Android affected?: no

Comment 4

[Sarah Chung [:sachung]]

Attachment: Bug 1995928 - Prevents spotlight from closing if enter is pressed while file path is focused

Original Revision: https://phabricator.services.mozilla.com/D270245

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/b043ae389013

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2a05867c5d40
https://hg.mozilla.org/releases/mozilla-beta/rev/5919def122f9

Comment 7

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 146.0a1 (Build ID: 20251030094725) and Firefox Beta 145.0b8 (Build ID: 20251029090400) on Windows 10 x64.

• The spotlight remains displayed when pressing the “Enter” key while the backup path field is focused on the Location screen.