1996020 - Crash in [@ webrtc::webrtc_checks_impl::WriteFatalLog]

Status: REOPENED

(Core :: WebRTC, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The volume for this crash signature increased with the release of Firefox 144.0.

Michael, does anything need to be done here?

Crash report: https://crash-stats.mozilla.org/report/index/16c21013-e56e-42a9-a5f4-cb4be0251023

Reason:

EXCEPTION_BREAKPOINT

Top 10 frames:

0  KERNELBASE.dll  wil::details::DebugBreak(void)
1  xul.dll  webrtc::webrtc_checks_impl::WriteFatalLog(std::basic_string_view<char, std::c...  third_party/libwebrtc/rtc_base/checks.cc:76
2  xul.dll  webrtc::webrtc_checks_impl::WriteFatalLog(char const*, int, std::basic_string...  third_party/libwebrtc/rtc_base/checks.cc:84
3  xul.dll  webrtc::webrtc_checks_impl::FatalLog(char const*, int, char const*, webrtc::w...  third_party/libwebrtc/rtc_base/checks.cc:179
4  xul.dll  webrtc::webrtc_checks_impl::LogStreamer<>::Call(char const*, const int, char ...  third_party/libwebrtc/rtc_base/checks.h:263
4  xul.dll  webrtc::webrtc_checks_impl::LogStreamer<webrtc::webrtc_checks_impl::Val<9, co...  third_party/libwebrtc/rtc_base/checks.h:314
4  xul.dll  webrtc::webrtc_checks_impl::FatalLogCall<0>::operator&(webrtc::webrtc_checks_...  third_party/libwebrtc/rtc_base/checks.h:351
4  xul.dll  webrtc::AlignedMalloc(unsigned long long, unsigned long long)  third_party/libwebrtc/rtc_base/memory/aligned_malloc.cc:66
5  xul.dll  webrtc::I420Buffer::I420Buffer(int, int, int, int, int)  third_party/libwebrtc/api/video/i420_buffer.cc:66
5  xul.dll  webrtc::RefCountedObject<webrtc::I420Buffer>::RefCountedObject(int&, int&, in...  third_party/libwebrtc/rtc_base/ref_counted_object.h:34

Comment 1

[Michael Froman [:mjf]]

I'm not sure why we see a jump lately, but this really seems to start back in June where it when from 1 or 2 per day to spikes of double-digits per day.

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1996020 - use frame buffer pool in DesktopCaptureImpl::OnCaptureResult r?dbaker!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/803cd3c7617f
https://hg.mozilla.org/integration/autoland/rev/8e5342b1389d
use frame buffer pool in DesktopCaptureImpl::OnCaptureResult r=dbaker

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/8e5342b1389d

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c4592fa36205
https://hg.mozilla.org/integration/autoland/rev/d8cd183e8be0
Revert "Bug 1996020 - use frame buffer pool in DesktopCaptureImpl::OnCaptureResult r=dbaker" for causing mda failures @ test_peerConnection_basicScreenshare.html

Comment 6

[amarc]

Backed out for causing mda failures @ /test_peerConnection_basicScreenshare.html

• Backout link
• Push with failures
• Failure Log

Comment 7

[Michael Froman [:mjf]]

The tsan failure was caused by Bug 1997266. Now that it is fixed, I'll try relanding.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5e579f1966d6
https://hg.mozilla.org/integration/autoland/rev/9b7c4f7c8471
use frame buffer pool in DesktopCaptureImpl::OnCaptureResult r=dbaker

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9b7c4f7c8471