1996103 - Fix issues with collapsing a tab group that contains a split view

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser: Split View, defect)

Description

[Kelly Cochrane [:kcochrane]]

Two issues are going on here:
When collapsing a tab group that contains a split view and no other tabs, the split view is still shown rather than hidden as expected and the overflow count reads "+0". We shouldn't be displaying any overflow count that's less than 1.

Another issue I've seen with tab groups that contain nothing but a split view is that there's supposed to be a transition when collapsing/expanding the tab group that doesn't seem to be applying to the split view.

Note there's already another bug on file for collapsing a tab group not hiding the split view when it doesn't contain an active tab (bug 1995257).

Specs
Tech Spec Doc

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1996103 - Fix issues with collapsing a tab group that contains a split view

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e957f391a8f3
https://hg.mozilla.org/integration/autoland/rev/38fc633e08c1
Fix issues with collapsing a tab group that contains a split view r=tabbrowser-reviewers,nsharpley,sthompson

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/38fc633e08c1

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified that:

• Collapsing a tab group that contains a split view while the split view is not selected will collapse the tab group as expected.
• The overflow count no longer shows a 0 value when collapsing a tab group that contains only a split view