1996125 - Refactor test_moz_input_elems_in_form.html

Status: ASSIGNED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

There's a lot of duplicated logic in this test that should be refactored. For example:

• The template functions
  • The only difference is one has the form elements within the <form> tags, and the other has the input elements outside of the form with these elements using the form attribute
• The various assert* event handlers can most likely be pulled out of the tasks and used as global functions
• The *with_form_attribute tasks since they're copies of the submission and reset tasks respectively
• Most of the is asserts can probably be pulled into various functions so that we can reduce the number of lines

Additionally, we should have some dynamic way of determining valid moz-* input elements since this test will need to be modified as soon as a new moz input element is created.

Comment 1

[Daniel Singer]

Hi there,
I'd like to take on this patch. I'll let you know if I have any questions.
Thanks!