1996265 - firefox nightly fails to compile with: ../security/sandbox/linux/Sandbox.cpp:782:3: error: 'Unused' was not declared in this scope'

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[tt_1]

Attachment: ansifilter.log.gz

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0

Steps to reproduce:

I downloaded latest firefox-146.0 git sources and compiled them

Actual results:

20445348-43:10.53 /usr/bin/armv7a-unknown-linux-gnueabihf-g++ --sysroot /usr/armv7a-unknown-linux-gnueabihf -o Unified_cpp_sandbox_linux2.o -c -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox_build/dist/system_wrappers -include /home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DNS_NO_XPCOM -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/security/sandbox/linux -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox_build/security/sandbox/linux -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/security/sandbox/linux -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/security/sandbox/chromium-shim -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/security/sandbox/chromium -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/security/sandbox/chromium-shim/base/allocator/partition_allocator/src -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/security/sandbox/chromium/base/allocator/partition_allocator/src -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/third_party/abseil-cpp -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/nsprpub -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/mozglue/baseprofiler/core -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox_build/dist/include -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/nspr -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/nss -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/nspr -I/home/tmp/portage/portage/www-client/firefox-146.0/work/firefox_build/dist/include/nss -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/libpng16 -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/pixman-1 -DMOZILLA_CLIENT -include /home/tmp/portage/portage/www-client/firefox-146.0/work/firefox_build/mozilla-config.h -mfloat-abi=hard -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -pipe -fPIC -pipe -fomit-frame-pointer -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-invalid-offsetof -Wcomma-subscript -Wvolatile -Wno-deprecated-enum-enum-conversion -Wno-error=deprecated -Wduplicated-cond -Wimplicit-fallthrough -Wlogical-op -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wformat -Wformat-security -Wformat-overflow=2 -Wno-psabi -Wno-error=builtin-macro-redefined -Wno-error=stack-protector -fno-strict-aliasing -ffp-contract=off -MD -MP -MF .deps/Unified_cpp_sandbox_linux2.o.pp -fdiagnostics-color Unified_cpp_sandbox_linux2.cpp
20448345-43:10.53 In file included from Unified_cpp_sandbox_linux2.cpp:128:
20448412-43:10.53 /home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/security/sandbox/linux/Sandbox.cpp: In function 'void mozilla::SetMediaPluginSandbox(const char*)':
20448591:43:10.53 /home/tmp/portage/portage/www-client/firefox-146.0/work/firefox-146.0/security/sandbox/linux/Sandbox.cpp:782:3: error: 'Unused' was not declared in this scope; did you mean 'unused_t'?
20448785-43:10.53 782 | Unused << dlopen("libgcc_s.so.1", RTLD_GLOBAL|RTLD_LAZY);
20448862-43:10.54 | ^~~~~~
20448888-43:10.54 | unused_t

Expected results:

I expect the compile to pass smoothly

the full and compressed build log is attached

this is from cross-compiling to armv7a, but I don't think this has anything to do with compiling for arm

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Security: Process Sandboxing' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:sergesanspaille, since you are the author of the regressor, bug 1994397, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[[:sergesanspaille]]

I believe this is fixed in bookmarks/central, can you update, check and, if you can reproduce, share the faulty sha1? thanks!

Comment 4

[tt_1]

the compile works again with a fresh checkout