1996423 - Improve embedding of browser logo in generated QR codes

Status: RESOLVED FIXED

(Toolkit :: General, enhancement, P3)

Description

[Andrew Overholt [:overholt]]

Bug 1996315 just puts a white circle around the browser logo and centres it in the generated QR code. We can do better.

Comment 1

[Andrew Overholt [:overholt]]

Attachment: Bug 1996423 - Improve embedding of browser logo in generated QR codes. r=mconley

Comment 2

[Andrew Overholt [:overholt]]

Attachment: Bug 1996423 - Add tests for improved QR code logo embedding. r=mconley

Comment 3

[Andrew Overholt [:overholt]]

Attachment: Bug 1996423 - Minor style cleanup in QRCodeWorker. r=mconley

Comment 4

[Andrew Overholt [:overholt]]

One thing to note here is that for longer URLs, the QR encoding of them can require alignment patterns (they look like 4 little squares in the cardinal directions with single dots in the centre) and those can end up in the centre of the resulting QR code. That results in off-centre logo overlays which may not be what we want. For now, I think we should proceed, and can easily re-evaluate and drop logo overlays in these situations.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/64ed431392f7
https://hg.mozilla.org/integration/autoland/rev/d279335aeeaf
Improve embedding of browser logo in generated QR codes. r=mconley
https://github.com/mozilla-firefox/firefox/commit/667c7f202de4
https://hg.mozilla.org/integration/autoland/rev/2cfbad317825
Add tests for improved QR code logo embedding. r=mconley
https://github.com/mozilla-firefox/firefox/commit/3229391ec753
https://hg.mozilla.org/integration/autoland/rev/db63684a93a7
Minor style cleanup in QRCodeWorker. r=mconley

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d279335aeeaf
https://hg.mozilla.org/mozilla-central/rev/2cfbad317825
https://hg.mozilla.org/mozilla-central/rev/db63684a93a7