Closed
Bug 1996605
Opened 8 months ago
Closed 7 months ago
Pass CycleCollectedJSContext to CallSetup constructors where available
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
146 Branch
| Tracking | Status | |
|---|---|---|
| firefox146 | --- | fixed |
People
(Reporter: mgaudet, Assigned: bthrall)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently there's are two TLS lookups happening during CallSetup for microtask handling, but these aren't actually necessary as we could pipe the CycleCollectedJSContext through avoiding them in the common case.
See this profile of Doxbee-promise showing TLS lookup as the top self-function: https://share.firefox.dev/4ozDHjf
| Assignee | ||
Updated•8 months ago
|
Severity: -- → N/A
Priority: -- → P3
| Assignee | ||
Comment 1•8 months ago
|
||
Updated•8 months ago
|
Assignee: nobody → bthrall
Status: NEW → ASSIGNED
Pushed by bthrall@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/bf30ffb3cfae
https://hg.mozilla.org/integration/autoland/rev/c37ed92d59b0
Get CycleCollectedJSContext once instead of twice in CallSetup r=smaug
Comment 3•7 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox146:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
Updated•7 months ago
|
QA Whiteboard: [qa-triage-done-c147/b146]
You need to log in
before you can comment on or make changes to this bug.
Description
•