1996806 - Refactor deleteAndQuit and remove casts to HomeActivity when calling the method.

Status: RESOLVED FIXED

(Firefox for Android :: General, task)

Description

[Mihai Adrian Carare [:mcarare]]

We should also centralizes the creation of the controller in the calling classes (BaseBrowserFragment, HomeFragment, MenuDialogFragment) and simplify the deleteAndQuit function.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::Tooling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1996806 - Centralize and improve "delete data on quit" logic

This patch refactors the "delete browsing data on quit" feature to improve its structure, testability, and reliability.

The core changes include:

• Refactoring deleteAndQuit into a new deleteDataAndQuit extension of DeleteBrowsingDataController
• This new structure ensures that the app termination logic (e.g., finishAndRemoveTask()) is always called, even if data deletion fails.
• The DeleteBrowsingDataController is now instantiated and passed down from UI entry points (HomeFragment, BaseBrowserFragment), making the feature's dependencies explicit and improving testability.
• Added comprehensive unit tests for the deleteDataAndQuit logic covering various scenarios.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c872c9e69a67
https://hg.mozilla.org/integration/autoland/rev/193ee3d42b12
Centralize and improve "delete data on quit" logic r=android-reviewers,jonalmeida

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/193ee3d42b12